Skip to content

Always init the BG opacity with the renderer#11368

Merged
1 commit merged intomainfrom
dev/migrie/b/11315-cleartype-oof
Sep 29, 2021
Merged

Always init the BG opacity with the renderer#11368
1 commit merged intomainfrom
dev/migrie/b/11315-cleartype-oof

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Sep 29, 2021

Missed this in #11180. I forgot to init the BG opacity with the renderer on startup, because that matters when you have "antialiasingMode": "cleartype",.

Repro json

{
    "commandline": "cmd.exe",
    "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
    "hidden": false,
    "opacity": 35,
    "antialiasingMode": "cleartype",
    "padding": "0",
    "name": "Command Prompt"
},

@zadjii-msft
Always init the BG opacity with the renderer
76e3477 
  Missed this in #11180. I forgot to init the BG opacity with the renderer on startup, because that matters when you have `"antialiasingMode": "cleartype",`.

  Repro json
  ```json
    {
        "commandline": "cmd.exe",
        "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
        "hidden": false,
        "opacity": 35,
        "antialiasingMode": "cleartype",
        "padding": "0",
        "name": "Command Prompt"
    },
  ```

  * [x] Fixes #11315
@ghost ghost added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Sep 29, 2021
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d25ca26 into main Sep 29, 2021
@ghost ghost deleted the dev/migrie/b/11315-cleartype-oof branch September 29, 2021 21:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees

No one assigned

Labels

Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1.12: I'm betting there's weirdness with vintage opacity and cleartype

3 participants

@zadjii-msft @carlos-zamora @miniksa