Merged
Conversation
Member
zadjii-msft
commented
Sep 15, 2021
- this is the same thing as Upgrade to Microsoft.UI.Xaml 2.6.2 (or equivalent) #10996, but with the fix that caused us to Revert "Upgrade to Microsoft.UI.Xaml 2.6.2 (or equivalent)" #11031
- This includes TabViewItem: Respect Background & Foreground APIs microsoft-ui-xaml#3769, so we had to make some adjustments to how we handle tab colors. It works the same as before.
- Should enable [UX] Adopt Windows 11 Fluent styling for Settings #11231 to be started
- Closes Update to WinUI 2.6 (prerelease) #10508
- Closes The rounded bottom corner on a tab doesn't get colored by the color picker #7133
- Closes Saving the settings.json file creates a shadow on the tab? #8948
- I need to finish letting my 19H1 VM boot to make sure unpackaged still works
This reverts commit d112bd9.
carlos-zamora
approved these changes
Sep 15, 2021
| <!-- Include the MUX Controls resources --> | ||
| <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" /> | ||
| <XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" | ||
| ControlsResourcesVersion="Version1" /> |
Member
There was a problem hiding this comment.
Curious: Why did we have to add the version here?
Member
Author
There was a problem hiding this comment.
totally unfounded guess: this opts us out of the win11 styles, until we're ready to actually ingest them. Dustin did it in the original PR
Member
Author
|
Blocking because this explodes on 19H1 @msftbot make sure @DHowett signs off on this |
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
approved these changes
Sep 20, 2021
Member
DHowett
left a comment
There was a problem hiding this comment.
I wish this didn't explode our msixbundle by 10MB, but what can ya do
zadjii-msft
added a commit
that referenced
this pull request
Sep 29, 2021
DESPITE the fact that there's a `Background()` API that we
could just call like:
```c++
TabViewItem().Background(deselectedTabBrush);
```
We actually can't, because it will make the part of the tab that
doesn't contain the text totally transparent to hit tests. So we
actually _do_ still need to set `TabViewItemHeaderBackground` manually.
* Regressed in #11240
* Root cause up in microsoft/microsoft-ui-xaml#3769
* [x] closes #11294
1 task
ghost
pushed a commit
that referenced
this pull request
Sep 29, 2021
DESPITE the fact that there's a `Background()` API that we could just call like: ```c++ TabViewItem().Background(deselectedTabBrush); ``` We actually can't, because it will make the part of the tab that doesn't contain the text totally transparent to hit tests. So we actually _do_ still need to set `TabViewItemHeaderBackground` manually. * Regressed in #11240 * Root cause up in microsoft/microsoft-ui-xaml#3769 * [x] closes #11294
2 tasks
ghost
pushed a commit
that referenced
this pull request
Oct 5, 2021
I've had a hard time with the tab colors this week. Turns out that setting the background to nullptr will make the tabviewitem invisible to hit tests. `Transparent`, on the other hand, is totally valid, and the expected default. Tabs as of this commit:  ## PR Checklist * [x] Closes #11382 * [x] I work here This low-key reverts a bit of #11369, which fixed #11294, which regressed in #11240
|
🎉 Handy links: |
This was referenced Oct 20, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.