Skip to content

Revert "Upgrade to Microsoft.UI.Xaml 2.6.2 (or equivalent)"#11031

Merged
DHowett merged 1 commit intomainfrom
revert-10996-dev/duhowett/mux-2.6
Aug 24, 2021
Merged

Revert "Upgrade to Microsoft.UI.Xaml 2.6.2 (or equivalent)"#11031
DHowett merged 1 commit intomainfrom
revert-10996-dev/duhowett/mux-2.6

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Aug 24, 2021

The upgrade to 2.6 revealed #11003 and microsoft/microsoft-ui-xaml#5435, and is impeding
progress on PGO.

Reverts #10996

@DHowett DHowett requested a review from miniksa August 24, 2021 21:42
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Contributor

@PankajBhojwani PankajBhojwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadge

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAD

@DHowett DHowett merged commit f3cc4c0 into main Aug 24, 2021
@zadjii-msft zadjii-msft mentioned this pull request Sep 15, 2021
4 tasks
ghost pushed a commit that referenced this pull request Sep 20, 2021
* this is the same thing as #10996, but with the fix that caused us to #11031  
* This includes microsoft/microsoft-ui-xaml#3769, so we had to make some adjustments to how we handle tab colors. It works the same as before.
* Should enable #11231 to be started
* [x] Closes #10508
* [x] Closes #7133
* [x] Closes #8948
* [ ] I need to finish letting my 19H1 VM boot to make sure unpackaged still works
@DHowett DHowett deleted the revert-10996-dev/duhowett/mux-2.6 branch October 26, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants