Fix directional movement during startup#11023
Conversation
|
Seriously, on every branch the feature tests fail? Is there a problem with the CI and running from forks or something? |
We recently moved to new build agents, and unfortunately some of our tests are timing-sensitive. I'll book some work for us to shore them up. Sorry about that 😄 |
|
I apologize, rereading my comment my wording could have been better. I meant to express surprise that this kept happening, not any sense of anger. |
|
Don't worry, none taken. We submit PRs more than anyone else, so yea this has been a major pain 🙃 |
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Thanks for whipping this up so fast!
zadjii-msft
added
Area-UserInterface
ghost
requested review from
DHowett,
PankajBhojwani,
carlos-zamora,
leonMSFT,
lhecker and
miniksa
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
This is amazing, and I love it. Thanks for the comprehensive fixes lately!
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
3 participants
During startup we do not have real dimensions, so we have to guess what
our dimensions should be based off of the splits.
We'll augment the state of the pane search to also have a size in each
dimension that gets incrementally upgraded as we recurse through the
tree.
References #10978