Merged
Conversation
This comment has been minimized.
This comment has been minimized.
carlos-zamora
approved these changes
Aug 9, 2021
3 tasks
zadjii-msft
added
Area-CodeHealth
lhecker
approved these changes
Aug 11, 2021
Member
lhecker
left a comment
lhecker
left a comment
There was a problem hiding this comment.
FYI: I'm going to remove the MapVirtualKeyW(hotkey.ScanCode(), MAPVK_VSC_TO_VK); in RegisterHotKey in a future PR.
| const auto result = ::RegisterHotKey(_window.get(), index, hotkeyFlags, vkey); | ||
| LOG_IF_WIN32_BOOL_FALSE(result); | ||
|
|
||
| TraceLoggingWrite(g_hWindowsTerminalProvider, |
Member
There was a problem hiding this comment.
Do we still need this when we now have the TraceLoggingWrite in the caller?
Member
Author
There was a problem hiding this comment.
IMO yes - they're logging different things. Theoretically they could be combined, but that would be more plumbing to get all the values in one place so meh ¯\_(ツ)_/¯
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This isn't a fix for #10875, but it is logging that help identify the root cause here. The logging may additionally be helpful for some of the other issues we're seeing elsewhere in the repo, namely #10340.
@lhecker is actually working on the fix for #10875, so hopefully this test will help validate.
References
PR Checklist
details
While I was here, I noticed that
KeyBindingsTests::KeyChordshas been broken for some time now. So I fixed that too.