Skip to content

Reload settings when the input method changes#10876

Merged
1 commit merged intomainfrom
dev/lhecker/10729-reload-locale-settings
Aug 5, 2021
Merged

Reload settings when the input method changes#10876
1 commit merged intomainfrom
dev/lhecker/10729-reload-locale-settings

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Aug 5, 2021

VkKeyScanW as well as MapVirtualKeyW are used throughout
the project, but are input method sensitive functions.

Since #10666 win+sc(41) is used as the quake mode keybinding,
which is then mapped to a virtual key in order to call RegisterHotKey.
This mapping is highly dependent on the input method and the quake mode
key binding will fail to work once the input method was changed.

PR Checklist

Validation Steps Performed

  • win+` opens quake window before & after changing keyboard layout ✔️
  • keyboard layout changes while WT is minimized trigger reloaded ✔️

@ghost ghost added Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Aug 5, 2021
lhecker
lhecker commented Aug 5, 2021
View reviewed changes
src/cascadia/TerminalApp/TerminalAppLib.vcxproj
<SubType>Designer</SubType>
</Page>
<Page Include="TabHeaderControl.xaml">
<Page Include="TabHeaderControl.xaml">
Copy link
Member Author

@lhecker lhecker Aug 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the two new files using Visual Studio instead of adding them by hand. Hence all these changes.
But I looked at them and thought that it's actually an appropriate cleanup and left it in this PR.

zadjii-msft
zadjii-msft approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fix #10875 by itself, right?

@lhecker
Copy link
Member Author

lhecker commented Aug 5, 2021

@zadjii-msft No. We could remove the ScanCode field from KeyChord, but this would break serialization. As such, I believe, we’re forced to make ActionMap not use KeyChord anymore, but a custom type which doesn’t have ScanCode instead.

@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit dcbf7c7 into main Aug 5, 2021
@ghost ghost deleted the dev/lhecker/10729-reload-locale-settings branch August 5, 2021 21:33
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 31, 2021
Closed
@lhecker lhecker mentioned this pull request Mar 13, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reload locale specific data when the input language or method changes

3 participants

@lhecker @carlos-zamora @zadjii-msft