Merged
Conversation
carlos-zamora
added
Product-Terminal
carlos-zamora
force-pushed
the
dev/cazamor/actions-page/add-action
branch
from
a543625 to
718b6b2
Compare
carlos-zamora
force-pushed
the
dev/cazamor/actions-page/add-action
branch
from
718b6b2 to
b1209ae
Compare
miniksa
reviewed
Jul 6, 2021
miniksa
requested changes
Jul 6, 2021
ghost
added
Needs-Author-Feedback
miniksa
approved these changes
Jul 7, 2021
Member
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
Much clearer. Thanks. Looks good.
zadjii-msft
approved these changes
Jul 7, 2021
| <comment>Text label for a button that can be used to begin making changes to a key binding entry.</comment> | ||
| </data> | ||
| <data name="Actions_AddNewTextBlock.Text" xml:space="preserve"> | ||
| <value>Add new</value> |
Member
There was a problem hiding this comment.
Perhaps this should be "Add new..."? eh, maybe not though. idc.
| KeyChordSerialization::FromString(newKeyChordText), // NewKeys: Attempt to convert the provided key chord text | ||
| _IsNewlyAdded ? hstring{} : _CurrentAction, // OldAction | ||
| unbox_value<hstring>(_ProposedAction)) }; // | ||
| _ModifyKeyBindingRequestedHandlers(*this, *args); |
Member
There was a problem hiding this comment.
note: this is handled in Actions::_ViewModelModifyKeyBindingHandler
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
12 tasks
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds the "add new" button to the actions page. It build on the work of #10220 by basically just adding a new list item to the top of the key binding list.
This also makes it so that if you click the "accept changes" button when you have an invalid key chord, we don't do anything.
References
#6900 - Actions page Epic
#9427 - Actions page design doc
#10220 - Actions page PR - set action
Detailed Description of the Pull Request / Additional comments
ModifyKeyBindingEventArgsis used to introduce new key bindings. We just ignoreOldKeysandOldActionNamebecause both didn't exist before.IsNewlyAddedtracks if this is an action that was added, but has not been confirmed to add to the settings model.CancelChanges()is directly bound to the cancel button. This allows us to delete the key binding when it's clicked on a "newly added" action.Validation Steps Performed