Conversation
[skip ci]
This comment has been minimized.
This comment has been minimized.
|
This looks promising! |
|
|
||
| ### Enabling notifications | ||
|
|
||
| **NOTE**: Our pipeline is already set up with this functionality. However, here is a quick guide on how to get it set up and modify it to our liking. |
There was a problem hiding this comment.
Discussion
This isn't strictly true yet. In fact, it seems like we won't be getting much benefit yet until we set up notifications. The question is, what do we want to see here.
There was a problem hiding this comment.
I like the multiple notification systems. We for-sure need it to be writing our bugs to our Azure Devops path. But I think we could resurrect the Notifications channel in Teams for this sort of thing. Can it send email? I'm just concerned it needs to be someplace we look frequently because when we are running Helix tests nightly... we keep missing the failures since it doesn't have adequate notification capability set up.
There was a problem hiding this comment.
I forget why exactly, but I remember speaking with Dustin about this over the summer, and there was some kind of issue with Teams specifically. For now, I've set up the notification system to generate ADO work items and assign them to me.
build/pipelines/fuzz.yml
Outdated
| - bash: | | ||
| set -ex | ||
| pip -q install onefuzz | ||
| onefuzz config --endpoint $(endpoint) --client_id $(client_id) --client_secret $(client_secret) | ||
| onefuzz template libfuzzer basic OpenConsole WriteCharsLegacy $(commitSHA1) windows --target_exe $(artifactsPath)/$(publishedArtifactsPath)/Fuzzing/x64/test/OpenConsoleFuzzer.exe |
There was a problem hiding this comment.
One limitation right now is that this is just running one fuzzer. But we also only have one fuzzer.
So we'll have to make a minor change here once we get more fuzzers.
There was a problem hiding this comment.
Could you make the rest of the path one of your inputs so we can easily adapt it in the future? It could then just turn into a template super quick.
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
If it works, it works. Thanks for pulling this together, Carlos.
|
|
||
| ### Enabling notifications | ||
|
|
||
| **NOTE**: Our pipeline is already set up with this functionality. However, here is a quick guide on how to get it set up and modify it to our liking. |
ghost
added
the
Needs-Author-Feedback
ghost
added
the
No-Recent-Activity
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
miniksa
removed
the
No-Recent-Activity
ghost
removed
the
Needs-Author-Feedback
|
DO NOT AUTOMERGE My internet is really bad this week since I'm working remotely. So I'm gonna hold off on merging this until I get back to a stable connection (since this PR will create ADO tasks and assign them to me). NOTE: I still need to make that one-line change to activate notifications. So I'll do that next week and merge it so I can stay on top of it. Thanks all! |
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
## Summary of the Pull Request Modifies the OneFuzz CI Job so that it attempts to read the notification config from a file rather than the command line. ## References Potential oversight in #10431. ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments Noticed that the CI job was failing on main, so took a look. According to the [docs](https://github.com/microsoft/onefuzz/blob/7f7d76fa7fd0e351f8ffd8c7aa5c5729e30f9e8f/docs/notifications.md#implementation), files should be referenced using `@./` notation.
4 participants
Summary of the Pull Request
This PR sets up a OneFuzz pipeline on Azure DevOps for our repo.
Detailed Description of the Pull Request / Additional comments
References
#7638