Skip to content

Polish code for actions page#10173

Merged
1 commit merged intomainfrom
dev/cazamor/actions-page/follow-up
Jun 3, 2021
Merged

Polish code for actions page#10173
1 commit merged intomainfrom
dev/cazamor/actions-page/follow-up

Conversation

@carlos-zamora
Copy link
Member

Applies feedback from #9949 (review)

Highlights include:

  • bugfix: make all edit buttons stay visible if the user is using assistive technology
  • rename a few functions and resources to match the correct naming scheme
  • update the localized text for a conflicting key chord being assigned
  • provide better comments throughout the actions page code

References

#9949 - Original PR
Closes #10168

@carlos-zamora carlos-zamora requested a review from DHowett May 24, 2021 23:56
@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 24, 2021
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jun 2, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c9dc419 into main Jun 3, 2021
@ghost ghost deleted the dev/cazamor/actions-page/follow-up branch June 3, 2021 22:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply leftover PR feedback to Actions Page

3 participants