Don't yeet focus to the control when the tab renamer is opened#10114
Merged
3 commits merged intomainfrom May 18, 2021
Merged
Conversation
ghost
added
Area-UserInterface
DHowett
reviewed
May 17, 2021
| // GH#10112 - if we're opening the tab renamer, don't | ||
| // immediately toss focus to the control. We don't want to steal | ||
| // focus from the tab renamer. | ||
| if (!tab->_headerControl.InRename()) |
Member
There was a problem hiding this comment.
are we gonna have to start slapping "BODGY" on our own code that is workaround for other code of ours being wrong
Member
Author
There was a problem hiding this comment.
That sure is possible
DHowett
approved these changes
May 17, 2021
ghost
requested review from
PankajBhojwani,
carlos-zamora,
leonMSFT,
lhecker and
miniksa
carlos-zamora
approved these changes
May 17, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hotfix to #10048. When the tab renamer is opened, we need to make sure to not immediately steal focus from it.