This fixes summoning _quake as the MRU window#10108
Merged
Conversation
DHowett
approved these changes
May 17, 2021
ghost
requested review from
PankajBhojwani,
carlos-zamora,
leonMSFT,
lhecker and
miniksa
carlos-zamora
approved these changes
May 17, 2021
| @@ -308,7 +308,7 @@ namespace winrt::Microsoft::Terminal::Remoting::implementation | |||
| // actually on the current desktop. | |||
Member
There was a problem hiding this comment.
Please update the method description
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
Oh, the bot got hung up because of spellchecking. I'll manually merge. |
|
🎉 Handy links: |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This fixes a bug where if you had the
_quakewindow open, and you tried toglobalSummonit (not with thequakeModeaction, but just with a plain-oldglobalSummonto activate the MRU window), we'd create a new window instead of just summoning the_quakewindow.References
_quakewindow from glomming #9956PR Checklist
Detailed Description of the Pull Request / Additional comments
It's basically a one-line fix, I just had to update the function signature for
_getMostRecentPeasantIDto allow us to use it differently for glomming vs summoning. When glomming,ignoreQuakeWindowshould be true. When summoning,ignoreQuakeWindowshould be false.