Add "monitor": "any"|"toCurrent"|"toMouse" setting to globalSummon#10092
Merged
118 commits merged intomainfrom May 17, 2021
Merged
Add "monitor": "any"|"toCurrent"|"toMouse" setting to globalSummon#10092118 commits merged intomainfrom
"monitor": "any"|"toCurrent"|"toMouse" setting to globalSummon#10092118 commits merged intomainfrom
Conversation
…ompile a String[]
…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
…safely tear it down. It _seems_ like it.
…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.
…/quake-toggleVisibility
…quake-dropdown-final
This comment has been minimized.
This comment has been minimized.
61 tasks
Member
|
Man I make one comment in bug bash and here it is! Nice! |
miniksa
approved these changes
May 14, 2021
zadjii-msft
added
the
Area-Remoting
DHowett
reviewed
May 17, 2021
| // Summon the window whenever we dispatch a commandline to it. This will | ||
| // make it obvious when a new tab/pane is created in a window. | ||
| _window->SummonWindow(false, 0); | ||
| _window->SummonWindow(summonArgs); |
Member
There was a problem hiding this comment.
i know i asked you not to but also I don't care that much 😄
DHowett
approved these changes
May 17, 2021
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
make sure you don't automerge the base! 😄
…tor-toCurrent-with-dropdown
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds support for part of the
monitorproperty forglobalSummon. It also goes a little off-spec:monitor: This controls the monitor that the window will be summoned from/to"any": Summon the MRU window, regardless of which monitor it's currently on."toCurrent"/omitted: (default): Summon the MRU window TO the monitor with the current foreground window."toMouse": Summon the MRU window TO the monitor where the mouse cursor is.When I was playing with this, It felt like
toMousewas always what I wanted, nottoCurrent. We can always just comment that out if we think that's contentious - I'm aware I didn't originally spec that.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I made
toMousethe default because it felt better. fite-me.jpgValidation Steps Performed
my ever evolving blob:
{ "keys": "ctrl+`", "command": { "action": "quakeMode" } }, { "keys": "ctrl+1", "command": { "action": "globalSummon" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "toggleVisibility": false } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "dropdownDuration": 2000 } }, { "keys": "ctrl+2", "command": { "action": "globalSummon", "monitor": "any" } }, // { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } }, { "keys": "ctrl+3", "command": { "action": "globalSummon", "monitor": "toMouse" } }, // { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } }, { "keys": "ctrl+4", "command": { "action": "globalSummon", "monitor": "toMouse", "dropdownDuration": 500 } }, { "keys": "ctrl+5", "command": { "action": "globalSummon", "dropdownDuration": 500 } },