Allow program to work in non-English languages#10
Closed
gschizas wants to merge 2 commits intomicrosoft:masterfrom
Closed
Allow program to work in non-English languages#10gschizas wants to merge 2 commits intomicrosoft:masterfrom
gschizas wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Author
|
I'm removing this as duplicate, the very first PR handled this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a number should almost always contain the culture that the parsing should happen, otherwise local culture may break it. In the case of a standardized format (e.g. the itermcolor plist XML standard), the numbers use "." as the decimal separator, so the proper culture is the InvariantCulture. This is by definition the same as en_US, but it's more suited for parsing standardized strings such as this.