Skip to content

runxamlformat doesn't work in the tools directory #9768

@j4james

Description

@j4james

Windows Terminal version (or Windows build number)

7f5a19b

Other Software

No response

Steps to reproduce

  1. Checkout the Windows Terminal source code.
  2. Open a cmd shell.
  3. Change to the tools directory.
  4. Execute the razzle.cmd script to setup the dev environment.
  5. Execute the runformat.cmd script to validate the source code formatting.

Expected Behavior

The runformat script should execute successfully without any errors.

Actual Behavior

I got an error generated by the xstyler utility.

ERROR(S):
  Option 'f, file' has no value.

This seems to be caused by the new runxamlformat script (added in PR #9589), which is now called from the runformat script. As far as I can tell, it only works correctly if run from the root of the project. Not a major problem, but it's more convenient to run those tools from the actual tools directory where you have easy autocomplete.

Metadata

Metadata

Assignees

Labels

Area-BuildIssues pertaining to the build system, CI, infrastructure, metaIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-MetaThe product is the management of the products.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions