Skip to content

Code health: update every call of initializing TermControl with settings #9292

@PankajBhojwani

Description

@PankajBhojwani

In #8602, we started passing a child of the TerminalSettings to the control upon tab initialization, we need to make sure that we are doing this for every call of initializing a new TermControl (we initially forgot to do this for controls initialized during pane split, which led to #9280).

EDIT: Ideally, we do this by having a helper that handles the creation of new TermControls, see DHowett's comment below.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions