Skip to content

KeyChord should just use the existing WinRT types instead of defining our own #877

@zadjii-msft

Description

@zadjii-msft

Was looking at this in conjunction with resolving suggestions for #805. The XAML framework uses Windows::System::VirtualKey and Windows::System::VirtualKeyModifiers...is there a reason that Terminal should create their own types here that are now maintaining modifiers and enum values for something that already exists? Retrieving the keybindings with a KeyChord that has it's own values is proving to be challenging using them anywhere in the UI due to different types and not being able to cast them accordingly well.

Originally posted by @timheuer in #748 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Help WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions