-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-SettingsUIAnything specific to the SUIAnything specific to the SUIIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-2A description (P2)A description (P2)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
Description
In the Settings UI, settings that are stored as enums and are represented as ComboBoxes/RadioButtons are not ordered properly:
- "none" and "hidden" should always be shown last
- FontWeight should be in thickness order (with "Custom" being last), not alphabetical order
Technical Details
#8086 introduced a way to leverage the JSON_MAPPINGS (json string to enum setting mapping) as a way to expose that mapping into the TerminalSettingsEditor. Dustin reported that it seems that they are ordered according to the json strings being alphabetical, not the localized Settings UI string being alphabetical.
We probably need some kind of post-processing to establish a good ordering in the TerminalSettingsEditor or the EnumMapping in TerminalSettingsModel.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-SettingsUIAnything specific to the SUIAnything specific to the SUIIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-2A description (P2)A description (P2)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.