-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-SettingsUIAnything specific to the SUIAnything specific to the SUIIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-1A description (P1)A description (P1)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
Steps to reproduce
- Open Settings UI
- Have a profile ("Profile A") refer to a custom color scheme ("Color Scheme A")
- Go to the Color Schemes page
- Select "Color Scheme A"
- Rename it to something else ("Color Scheme B")
- Navigate back to the profile that referred to this color scheme ("Profile A")
Expected behavior
"Profile A" should now reference "Color Scheme B".
Actual behavior
"Profile A" refers to "Campbell"
Additional details
The TerminalSettingsModel stores Profile.ColorScheme as a string reference to the name of the ColorScheme.
In TerminalSettingsEditor (Profiles.cpp), if a ColorScheme with that name isn't found, we fallback to "Campbell".
Perhaps a better architecture would be to reference a ColorScheme object in the TerminalSettingsModel? Or at least reference a ColorScheme object in the ViewModel in TerminalSettingsEditor.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-SettingsUIAnything specific to the SUIAnything specific to the SUIIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Priority-1A description (P1)A description (P1)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.