Skip to content

Bad default selection background color with light schemes #8716

@austin-beer

Description

@austin-beer

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 1.4.3243.0

Steps to reproduce

  1. Update settings.json to use the One Half Light, Solarized Light, or Tango Light color schemes.
  2. Use the mouse to highlight some text.

Expected behavior

It's easy to see which text was selected.

Actual behavior

It's hard to see which text was selected because the default selectionBackground value is white, and that doesn't work well with light color schemes.

Proposed solution

Add selectionBackground values to all of the color schemes in defaults.json (or at least the light color schemes).

Related to

This issue is related to #3326, #3561, and #3580.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsIssues related to settings and customizability, for console or terminalHelp WantedWe encourage anyone to jump in on these.In-PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsPriority-3A description (P3)Product-TerminalThe new Windows Terminal.good first issueThis is a fix that might be easier for someone to do as a first contribution

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions