Skip to content

Card suite Unicode characters are the wrong width #5822

@j4james

Description

@j4james

Environment

Windows build number: Version 10.0.18362.657
Windows Terminal version (if applicable): Commit 7ae3433

Steps to reproduce

  1. Build commit 7ae3433
  2. Open a bash shell
  3. Execute printf "\u2660\u2663\u2665\u2666\n"

Expected behavior

This should print our the four card suite Unicode characters, each being one cell wide. Here's what it used to look like in conhost:

image

Actual behavior

Each characters occupies two cells now.

image

I wouldn't be too concerned if these were some recently invented emoji like crying kitten, or dancing monkey with umbrella. But these characters are from the default cmd shell code page (CP437), and they've been narrow characters for going on 40 years now. They're even included in the WGL4 character repertoire. Changing their width is almost guaranteed to break things.

I'm sorry I didn't bring this up before PR #5795 was merged, but I wasn't paying attention to the actual characters that were being changed. I only noticed now when I was testing some of my own code and found that this broke Vttest (it uses the diamond character in a couple of the tests).

Metadata

Metadata

Assignees

Labels

Area-ServerDown in the muck of API call servicing, interprocess communication, eventing, etc.Impact-CompatibilitySure don't work like it used to.Impact-CorrectnessIt be wrong.Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingPriority-0Bugs that we consider release-blocking/recall-class (P0)Product-ConhostFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions