-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Open
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-ScenarioProduct-ConptyFor console issues specifically related to conptyFor console issues specifically related to conpty
Milestone
Description
During 1.0, we discovered a ton of bugs in our resize with reflow implementation, and now that we need to keep both the conpty and the terminal in sync on these things, it's more important than ever to do these things right.
I'm collecting up all the straggling tasks I've found that might possibly be related.
This is a combo of "Make Reflow work correctly", and "Get rid of the spaghetti in the VtEngine related to line wrapping"
(see also #4200, the original reflow mega thread)
Issues
- Resize reflow tests #796 Resize reflow tests
- Resize with Reflow loses leading spaces on resize operation #797 Resize with Reflow loses leading spaces on resize operation
- WSL Terminal Line Endings (the "exact wrap" bug) #3088 WSL Terminal Line Endings (the "exact wrap" bug)
- [host] If a line is exactly the width of the buffer and you increase the buffer width, it will wrap incorrectly resize reflow #802 [host] If a line is exactly the width of the buffer and you increase the buffer width, it will wrap incorrectly resize reflow
- Conpty: Additional
ScrollFrameoptimizations #5228 Conpty: AdditionalScrollFrameoptimizations - [REGRESSION >0.11.1251] Backward-kill-word after line wrapping in powershell doesn't clear exited line properly [REGRESSION >0.11.1251] Backward-kill-word after line wrapping in powershell doesn't clear exited line properly #5839 (PR Fix an accidental regression from #5771 #5870)
- MSFT:19446208 - This code in
TextBuffer::Reflow - Some text not displayed when the screen scrolls #6566 Some text not displayed when the screen scrolls
- When Copying, Line Wrapped Text Is Inconsistently Broken Into Multiple Lines #6901 When Copying, Line Wrapped Text Is Inconsistently Broken Into Multiple Lines
- Multi-line paste with WSL omits and splices together lines #10833 Multi-line paste with WSL omits and splices together lines
- Extra newline when copying line with wide glyph on the edge #11739
- UIA in conhost: incorrect word boundaries when text is selected #11809
- No line wrap at the bottom of the Terminal window when entering text in TCC #7028 No line wrap at the bottom of the Terminal window when entering text in TCC
- Un-snapping Terminal Placing Cursor in Middle of Previous Command's Output #7253 Un-snapping Terminal Placing Cursor in Middle of Previous Command's Output
- (actually has a consistent repro)
- Rendering errors in tmux split panes #6987 Rendering errors in tmux split panes
- This might also be "Tmux pane content gets garbled after refreshing tmux client Tmux pane content gets garbled after refreshing tmux client #4029"
- conpty exhibits pathological performance on scrolling region redraw (repaints entire screen) #7019 conpty exhibits pathological performance on scrolling region redraw (repaints entire screen)
- Vanishing cursor and prints to wrong lines #7479
- Tab exits with code 1 when Console.SetBufferSize has been modified and you maximize window #7581
- Properly implement delayed EOL wrap in
Terminal::_WriteBuffer#12440, which might just be Implement stream writing mechanism on buffer (a.k.a. WriteCharsLegacy2ElectricBoogaloo) #780
Things I think will all be fixed by #8000
- Command History on wrong line #6546 Command History on wrong line
- Scrambled prompt/input area #10130
- Cursor position is lost when resizing the window if not on the bottom line #10848 Cursor position is lost when resizing the window if not on the bottom line
- Cursor position is lost when resizing the window horizontally #10868 also looks like this
PRs
Many of these are 1.0 PRs, but they've all got important context.
1.0 PRs
- Don't remove spaces when printing a new bottom line with a background color Don't remove spaces when printing a new bottom line with a background color #5550
- Fix wrapped lines in
lessin Git for Windows Fix wrapped lines inlessin Git for Windows #5771 - Don't duplicate spaces from potentially-wrapped EOL-deferred lines Don't duplicate spaces from potentially-wrapped EOL-deferred lines #5398
- Add a test to cover Decreasing the width of
vim.execorrupts buffer #5428 Add a test to cover #5428 #5449 - Fix copying wrapped lines by implementing better scrolling Fix copying wrapped lines by implementing better scrolling #5181
- Emit lines wrapped due to spaces at the end correctly Emit lines wrapped due to spaces at the end correctly #5294
- Fix an accidental regression from Fix wrapped lines in
lessin Git for Windows #5771 Fix an accidental regression from #5771 #5870
- Don't reflow a line as wrapped if it broke on the last cell Don't reflow a line as wrapped if it broke on the last cell #5368
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-ScenarioProduct-ConptyFor console issues specifically related to conptyFor console issues specifically related to conpty