-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-AccessibilityIssues related to accessibilityIssues related to accessibilityIssue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
Summary
Our TermControlUiaProvider (aka ScreenInfoUiaProvider) assumes that a retrieved selection is always a line selection.
Technical Details
ScreenInfoUiaProviderBase::GetSelection() returns a UiaTextRange for the endpoints of the selection (after a brief inclusive/exclusive conversion). We need two modifications here:
ScreenInfoUiaProviderBaseshould check if the selection is a box selection or a line selection. And should create a different branch for each of those options.UiaTextRangeBaseneeds...
- a constructor for a box selection UTR
- a flag to know if it is in this style
- a new bounding rect for a UTR of this style
- a modified way to retrieve text for this
-
(?) modifynot needed. How selections are made is already abstracted to the selection code, not UIA providersSelectto make a box selection?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-AccessibilityIssues related to accessibilityIssues related to accessibilityIssue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.