Skip to content

A {"action": "newTab", "profile": "NameOfProfile"} binding causes a crash #3897

New issue
New issue
Closed
#3901
Closed
A {"action": "newTab", "profile": "NameOfProfile"} binding causes a crash#3897
#3901
Assignees
zadjii-msft
Labels
Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.
Milestone
Terminal v0.8
@DHowett-MSFT

Description

@DHowett-MSFT
DHowett-MSFT
opened on Dec 10, 2019

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 420 to 429 in 402b7ff

const bool usedManualProfile = (newTerminalArgs != nullptr) && (newTerminalArgs.ProfileIndex().Value() || newTerminalArgs.Profile().empty());
TraceLoggingWrite(
g_hTerminalAppProvider, // handle to TerminalApp tracelogging provider
"TabInformation",
TraceLoggingDescription("Event emitted upon new tab creation in TerminalApp"),
TraceLoggingInt32(tabCount, "TabCount", "Count of tabs curently opened in TerminalApp"),
TraceLoggingBool(usedManualProfile, "ProfileSpecified", "Whether the new tab specified a profile explicitly"),
TraceLoggingGuid(profileGuid, "ProfileGuid", "The GUID of the profile spawned in the new tab"),
TraceLoggingKeyword(MICROSOFT_KEYWORD_MEASURES),
TelemetryPrivacyDataTag(PDT_ProductAndServicePerformance)); 

00 (Inline Function) --------`-------- TerminalApp!winrt::impl::consume_Windows_Foundation_IReference<winrt::Windows::Foundation::IReference<int>,int>::Value+0x4 [E:\BA\22\s\src\cascadia\TerminalApp\lib\Generated Files\winrt\Windows.Foundation.h @ 627] 
01 0000006b`126fda10 00007ffa`9189fc7e TerminalApp!winrt::TerminalApp::implementation::TerminalPage::_OpenNewTab+0xef [E:\BA\22\s\src\cascadia\TerminalApp\TerminalPage.cpp @ 420] 
02 0000006b`126fdb70 00007ffa`91852338 TerminalApp!winrt::TerminalApp::implementation::TerminalPage::_HandleNewTab+0x13e [E:\BA\22\s\src\cascadia\TerminalApp\AppActionHandlers.cpp @ 145]

It is in the ETL generator ☹️

Metadata

Metadata

Assignees

Labels

Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions