-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Interacting with the vintage console window (as opposed to driving via API or hooks)Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsPriority-1A description (P1)A description (P1)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.Crashes are real bad news.
Milestone
Description
Environment
Introduced by #2422
Since we'll be defaulting to the Windows Terminal default settings, this means that the user may be working with profiles that don't exist AFTER the proper settings are imported. Below is an example of such a case, but several other places may cause the same issue to arise.
I'd bet that this is because we usually use "FindProfile()" (or something like that) and we just don't handle that properly.
Steps to reproduce
- create a tab from the WT default settings
- import your custom settings
- duplicate the created tab
Expected behavior
Not sure. Maybe a dialogue box saying "This operation could not be completed"?
Actual behavior
CRASH!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Interacting with the vintage console window (as opposed to driving via API or hooks)Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsPriority-1A description (P1)A description (P1)Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.Crashes are real bad news.