Skip to content

Bug Report: Cannot find profile --> Crash #2455

@carlos-zamora

Description

@carlos-zamora

Environment

Introduced by #2422

Since we'll be defaulting to the Windows Terminal default settings, this means that the user may be working with profiles that don't exist AFTER the proper settings are imported. Below is an example of such a case, but several other places may cause the same issue to arise.

I'd bet that this is because we usually use "FindProfile()" (or something like that) and we just don't handle that properly.

Steps to reproduce

  • create a tab from the WT default settings
  • import your custom settings
  • duplicate the created tab

Expected behavior

Not sure. Maybe a dialogue box saying "This operation could not be completed"?

Actual behavior

CRASH!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsPriority-1A description (P1)Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions