Skip to content

Clean up the boundary between TerminalPage and TerminalApp #1878

@DHowett-MSFT

Description

@DHowett-MSFT

Right now, a lot of the logic for creating and maintaining a number of terminals lives in the TerminalApp::App singleton. That's not exactly correct by "xaml application" standards (nor is it correct by normal application standards.)

Pull request #XXX introduced a new xaml page that hosts the UI for the terminal. It should be tasked with maintaining the state of a number of terminal controls and connections so that ti becomes a reusable component. This may even be a step on the path to having multiple top-level windows hosting terminals -- if App can be the singleton in charge of settings and profile management, and a window can host a page instead of an App, we're in a better position to spawn more than one. 😄

thing currently should move
settings app -
settings reload app -
global error dialogs app ? not sure how this works in a multi-window world
ETW global registration app -
tab management app page
tab icons app page
clipboard management app ?
ETW tab logging app page
key bindings app page

Metadata

Metadata

Assignees

Labels

Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions