-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-WindowingWindow frame, quake mode, tearoutWindow frame, quake mode, tearoutIn-PRThis issue has a related PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.
Description
Failure ID 8ab19ec3-2532-a209-0ca4-5e6b9aa9133b
8.70% of our crashes in 1.19 so far.
Bug is here, on L1396.
terminal/src/cascadia/WindowsTerminal/AppHost.cpp
Lines 1390 to 1402 in 4382a17
| // For inexplicable reasons, again, hop to the BG thread, then back to the | |
| // UI thread. This is shockingly load bearing - without this, then | |
| // sometimes, we'll _still_ show the HWND before the XAML island actually | |
| // paints. | |
| co_await wil::resume_foreground(_windowLogic.GetRoot().Dispatcher(), winrt::Windows::UI::Core::CoreDispatcherPriority::Low); | |
| ShowWindow(_window->GetHandle(), nCmdShow); | |
| // If we didn't start the window hidden (in one way or another), then try to | |
| // pull ourselves to the foreground. Don't necessarily do a whole "summon", | |
| // we don't really want to STEAL foreground if someone rightfully took it | |
| const bool noForeground = nCmdShow == SW_SHOWMINIMIZED || |
Undoubtably, this is us not using a "weak ref". The app host got dtored during a Refrigerate, and so this is invalid on the other side of the co_await. Yikes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-WindowingWindow frame, quake mode, tearoutWindow frame, quake mode, tearoutIn-PRThis issue has a related PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.