Windows Terminal throws an exception on exit #15364
Description
Windows Terminal version
Commit ba39db5
Windows build number
10.0.19045.2728
Other Software
No response
Steps to reproduce
- Be on Windows 10 (I suspect this is necessary).
- Check out a recent commmit (ba39db5 or later).
- Build and run Windows Terminal from within Visual Studio.
- Exit the app.
Expected Behavior
It should shutdown gracefully.
Actual Behavior
It crashes with an exception:
Exception thrown at 0x00007FFCFE18D08E (Windows.UI.Xaml.dll) in WindowsTerminal.exe: 0xC0000005: Access violation reading location 0x0000000000000130.
Stack trace:
[Inline Frame] Windows.UI.Xaml.dll!DirectUI::DXamlCore::GetWindow() Line 278 C++
Windows.UI.Xaml.dll!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog() Line 2507 C++
Windows.UI.Xaml.dll!DirectUI::ContentDialog::~ContentDialog() Line 74 C++
Windows.UI.Xaml.dll!ctl::ComObject<DirectUI::ContentDialog>::`scalar deleting destructor'(unsigned int) C++
Windows.UI.Xaml.dll!ctl::ComBase::ReleaseImpl() Line 307 C++
> TerminalApp.dll!winrt::TerminalApp::implementation::TerminalWindow::~TerminalWindow() Line 68 C++
[External Code]
TerminalApp.dll!winrt::implements<winrt::TerminalApp::implementation::TerminalWindow,winrt::TerminalApp::TerminalWindow,winrt::TerminalApp::IDirectKeyListener,winrt::TerminalApp::IDialogPresenter,winrt::Windows::UI::Xaml::Data::INotifyPropertyChanged,IInitializeWithWindow>::Release() Line 8118 C++
[External Code]
[Inline Frame] WindowsTerminal.exe!std::_Func_class<float,bool,float>::_Tidy() Line 952 C++
[Inline Frame] WindowsTerminal.exe!std::_Func_class<float,bool,float>::{dtor}() Line 878 C++
WindowsTerminal.exe!IslandWindow::~IslandWindow() Line 41 C++
[External Code]
This looks very similar to #11980 and #13955, so I wouldn't be surprised if this is the MSFT:26130824 bug that is supposed to have been fixed in Windows 11. However, in my case there are no dialogs popping up, and there is nothing wrong with the settings (I reset my settings.json to the defaults).
Most importantly, though, I've only had this issue since PR #15338 was merged, and now I get it every time I run the app from within VS. So I don't mind if you also end up closing this as Resolution-External, but I thought it worth raising in case there's a more serious regression here.