Skip to content

ICH no longer works correctly on lines containing wide characters #14626

@j4james

Description

@j4james

Windows Terminal version

Commit 547349a

Windows build number

10.0.19044.2364

Other Software

No response

Steps to reproduce

  1. Create a build from the latest commit.
  2. Start Windows Terminal and open a WSL bash shell.
  3. Execute the following command: printf "\u3053\u3093\u306B\u3061\u306F World\r\e[@\n"

Expected Behavior

This should write out the text こんにちは World, and then insert a space at the start of the line via an ICH sequence. This is what it looks like in Preview version 1.16.2641.0:

image

Actual Behavior

When using the latest commit, the Japanese characters are erased by the ICH sequence, so all that's left is World.

image

So this looks to me like a regression, although I'm not sure when exactly it stopped working.

And note that this fails in OpenConsole as well. It's just easier to confirm that it's a recent regression in Windows Terminals because I know 1.16 was working OK.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-OutputRelated to output processing (inserting text into buffer, retrieving buffer text, etc.)Area-VTVirtual Terminal sequence supportIssue-BugIt either shouldn't be doing this or needs an investigation.Product-ConhostFor issues in the Console codebaseResolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-BlockingWe won't ship a release like this! No-siree.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions