Skip to content

Code Health: follow ups from connection restarting #14327

New issue
New issue
Closed
#15240
Closed
Code Health: follow ups from connection restarting#14327
#15240
Assignees
zadjii-msft
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIn-PRThis issue has a related PRIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Severity-BlockingWe won't ship a release like this! No-siree.
Milestone
Terminal v1.18
@zadjii-msft

Description

@zadjii-msft
zadjii-msft
opened on Nov 3, 2022

From #14060. See also #14060 (review)

The control shouldn't be responsible for restarting the connection itself. It should request a new one from the app.

  • Move this code to the page, and bubble an event to request a new connection
  • Revert this
  • Investigate only clearing the buffer to scrollback, instead of inheritCursoring

Metadata

Metadata

Assignees

Labels

Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIn-PRThis issue has a related PRIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Severity-BlockingWe won't ship a release like this! No-siree.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions