-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Interacting with the vintage console window (as opposed to driving via API or hooks)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
More of a mental note of all the misc. selection stuff I need to do. Hopefully I can get this in very soon so that we can verify that nothing was broken.
- Add testing for the following scenarios:
-
endSelectionPositionbeing located out of bounds
-
-
_GetSelectionRects()clean up- the pre-processing part is just a bit nasty now. There should be a way to simplify it. Need to be careful with testing this though.
- Proper selection mechanics
- when your
endSelectionPositionis out of bounds vertically, the x-position should still update, but the y-position should be at the boundary - when your
endSelectionPositionis out of bounds horizontally, the y-position should still update, but the y-position should be at the buffer boundary - this is particularly important for Feature Request: Scroll from selection dragging out of window #1247. As the y-position must be detected to be out of the bounds, so that's still valid. But it should be displayed as updating the x-position.
- when your
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-InteractionInteracting with the vintage console window (as opposed to driving via API or hooks)Interacting with the vintage console window (as opposed to driving via API or hooks)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.