-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Closed
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Description
While reading code in TermControl.cpp i stumble upon two lines of code that are absolutely the same and are called one after another.
terminal/src/cascadia/TerminalControl/TermControl.cpp
Lines 333 to 334 in 670ae2b
| const auto bg = newAppearance.DefaultBackground(); | |
| _changeBackgroundColor(bg); |
terminal/src/cascadia/TerminalControl/TermControl.cpp
Lines 380 to 381 in 670ae2b
| const auto bg = newSettings.DefaultBackground(); | |
| _changeBackgroundColor(bg); |
They are both called from TermControl::UpdateSettings()
_UpdateSettingsFromUIThread -> _ApplyUISettings and _UpdateAppearanceFromUIThread
Not sure if this is because of the situations in which this functions might be called separately but this just looks weird
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.