Skip to content

Crash in main when writing settings to disk twice #10003

@PankajBhojwani

Description

@PankajBhojwani

Windows Terminal version (or Windows build number)

main

Other Software

N/A

Steps to reproduce

  1. Open SUI
  2. Navigate to any profile
  3. Change any setting
  4. Hit 'Save'
  5. Hit 'Save' again
  6. Crash

Alternatively:

  1. Open SUI
  2. Add a new profile
  3. Hit 'Save'
  4. Hit 'Save' again
  5. Crash

Expected Behavior

No crash

Actual Behavior

Terminal crashes. The crash seems to happen in the Model::DefaultTerminal::Current(_currentDefaultTerminal); call in CascadiaSettings::WriteSettingsToDisk(), added in #9907

Metadata

Metadata

Assignees

Labels

Area-SettingsUIAnything specific to the SUIIssue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions