Skip to content

Bump MSAL Node to v5#603

Merged
heyitsaamir merged 1 commit into
mainfrom
bump-msal-node-5
Jun 2, 2026
Merged

Bump MSAL Node to v5#603
heyitsaamir merged 1 commit into
mainfrom
bump-msal-node-5

Conversation

@heyitsaamir

@heyitsaamir heyitsaamir commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps @azure/msal-node in @microsoft/teams.apps to v5.2.2.
  • Updates the token manager test mock for MSAL's fromNativeBroker -> fromPlatformBroker rename.

Why

  • Gets our direct MSAL dependency onto the current v5 line and removes the direct vulnerable uuid dependency path from @microsoft/teams.apps.

Interesting bits

  • I left BotBuilder alone, so npm audit still reports the existing BotBuilder/Restify transitive stuff. No spicy force-downgrades today.

Testing

Tested using User Managed Identity, FIC (UMI) and FIC system, and ofcourse secrets.

Copilot AI review requested due to automatic review settings May 30, 2026 00:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps @azure/msal-node from v3 to v5.2.2 in @microsoft/teams.apps to drop the vulnerable transitive uuid dependency, and updates the token-manager test mock to match MSAL v5's fromNativeBrokerfromPlatformBroker rename.

Changes:

  • Upgrade @azure/msal-node dependency to ^5.2.2 in packages/apps/package.json.
  • Update test mock field name fromNativeBrokerfromPlatformBroker in token-manager.spec.ts.
  • Refresh package-lock.json to reflect new MSAL v5 / msal-common 16 versions.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/apps/package.json Bumps @azure/msal-node to ^5.2.2.
packages/apps/src/token-manager.spec.ts Renames mocked field to fromPlatformBroker for MSAL v5 compatibility.
package-lock.json Lockfile updated to MSAL v5.2.2 / msal-common 16.6.2; removes nested uuid dep.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@heyitsaamir
heyitsaamir requested review from corinagum and rido-min May 31, 2026 22:06
@heyitsaamir
heyitsaamir added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 79544fe Jun 2, 2026
7 checks passed
@heyitsaamir
heyitsaamir deleted the bump-msal-node-5 branch June 2, 2026 16:16
corinagum added a commit that referenced this pull request Jun 15, 2026
## Release 2.0.13

Merges main into release for stable publish.

### Notable changes since 2.0.12
- fix(client): use explicit Graph scopes for Teams Desktop NAA
compatibility (#616)
- ci: switch publish pipeline to 1ES Official template for CodeQL/SDL
(#607)
- ci: add weekly SDL pipeline for CodeQL/CredScan compliance (#608)
- Refresh teams.apps README (#604)
- Reject unauthenticated when no credentials (#506)
- fix(api): conditionally set citation encodingFormat based on text
presence (#579)
- Improvements to the Teams MCP server example (#597)
- Bump MSAL Node to v5 (#603)
- Merge root message entities in Activity (#590)
- TeamsSDK: Correct imports and return types in misc. packages (#589)
- Cache federated identity MSAL clients (#613)

### Release steps
1. Merge this PR
2. Trigger the [release
pipeline](https://dev.azure.com/DomoreexpGithub/Github_Pipelines/_build?definitionId=52&_a=summary)
for `release` branch with **Public** publish type
3. Bump version on main to `2.0.14-preview.{height}`
4. Create git tag and GitHub Release page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants