fix: address npm audit vulnerabilities#546
Merged
Merged
Conversation
override follow-redirects (>=1.16.0) and path-to-regexp (^8.4.0 scoped to router) to fix auth header leak and ReDoS. bump axios to ^1.15.2 in common/apps/dev. remaining 14 are upstream botbuilder/azure deps we can't control. Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency versions and root-level npm overrides to reduce npm audit vulnerability count across the workspace, focusing on known issues in follow-redirects (auth header leak) and path-to-regexp (ReDoS), plus aligning axios to a patched version.
Changes:
- Bump
axiosto^1.15.2inpackages/apps,packages/common, andpackages/dev. - Add root
overridesforfollow-redirectsand scopedpath-to-regexpunderrouterto mitigate reported vulnerabilities.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dev/package.json | Bumps axios dependency to a patched version. |
| packages/common/package.json | Bumps axios dependency to a patched version. |
| packages/apps/package.json | Bumps axios dependency to a patched version. |
| package.json | Adds npm overrides for vulnerable transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
^1.16.0 instead of >=1.16.0 to avoid pulling a future 2.x breaking change Co-Authored-By: Claude <[email protected]>
corinagum
previously approved these changes
Apr 29, 2026
Co-Authored-By: Claude <[email protected]>
corinagum
approved these changes
Apr 30, 2026
4 tasks
heyitsaamir
added a commit
that referenced
this pull request
Apr 30, 2026
## Summary - the previous audit fix PR (#546) merged overrides for `follow-redirects` and `path-to-regexp`, but the lockfile merge resolved from main without them applied - clean `rm -rf node_modules package-lock.json && npm install` to get overrides into the lockfile - drops audit from 26 vulns (3 high, 1 critical) → 14 (0 high, 0 critical). remaining 14 are all upstream botbuilder/azure uuid+elliptic ## Test plan - [x] `npm audit` — 14 remaining, 0 high, 0 critical - [x] `npm run build` — all tasks pass - [x] `npm run test` — all test suites pass - [x] verify examples still build: `examples/echo`, `examples/botbuilder`, `examples/a2a` Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
follow-redirects(>=1.16.0) andpath-to-regexp(^8.4.0, scoped torouter) to fix auth header leak and ReDoS vulnsaxiosto ^1.15.2 in common/apps/devTest plan
npm run build— all 34 tasks passnpm run test— all 15 test suites passnpm run lint— all 33 tasks passnpm audit— confirms 14 remaining (all botbuilder/uuid/elliptic)examples/echo— basic app works (exercises express 5 + axios + follow-redirects)examples/a2a— express 4 not broken by scoped path-to-regexp overrideexamples/http-adapters— express 5 + restify still workexamples/botbuilder— botbuilder still works with unchanged transitive deps