Skip to content

chore(client): remove unused uuid dependency#539

Merged
lilyydu merged 1 commit into
mainfrom
lilyydu/dependabot-uuid
Apr 24, 2026
Merged

chore(client): remove unused uuid dependency#539
lilyydu merged 1 commit into
mainfrom
lilyydu/dependabot-uuid

Conversation

@lilyydu

@lilyydu lilyydu commented Apr 23, 2026

Copy link
Copy Markdown
Contributor
  • Removed uuid from @microsoft/teams.client dependencies — it's declared but never imported anywhere in
    packages/client/.
  • Resolves Dependabot alert for GHSA-w5hq-g745-h8pq in downstream consumers (e.g.
    microsoft/teams.py#80).

uuid ^11.0.5 has been in teams.client's package.json since the initial commit but is unused in source. Other packages
that do use uuid (packages/dev, external/a2a) only call v4, which isn't affected by the advisory.

Copilot AI review requested due to automatic review settings April 23, 2026 22:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused uuid dependency from the @microsoft/teams.client package to eliminate an unnecessary dependency and address downstream Dependabot advisory noise.

Changes:

  • Removed uuid from packages/client/package.json dependencies.
  • Updated package-lock.json to reflect the dependency removal for the packages/client workspace package.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/client/package.json Drops the unused uuid dependency from @microsoft/teams.client.
package-lock.json Updates the workspace lock entry for packages/client to no longer include uuid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@heyitsaamir

Copy link
Copy Markdown
Collaborator

We should use knip this this repo.

@lilyydu
lilyydu merged commit 231b1c3 into main Apr 24, 2026
11 checks passed
@lilyydu
lilyydu deleted the lilyydu/dependabot-uuid branch April 24, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants