Remove supportsThreading guard from app.reply()#533
Merged
Conversation
This reverts commit 626fe8a.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the SDK-side threading allowlist and makes App.reply(conversationId, messageId, activity) always construct a threaded conversation ID via toThreadedConversationId(), delegating “threading supported?” decisions to the service.
Changes:
- Remove
supportsThreading()/THREADING_SUFFIXESand associated unit tests. - Update
App.reply()(3-arg overload) to always usetoThreadedConversationId()whenmessageIdis provided. - Update the threading example and README to remove the conversation-type guard and adjust notes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/apps/src/utils/thread.ts | Removes suffix allowlist and supportsThreading() helper. |
| packages/apps/src/utils/thread.spec.ts | Drops supportsThreading() tests; keeps toThreadedConversationId() coverage. |
| packages/apps/src/app.ts | Removes supportsThreading() guard; always threads in 3-arg reply(), updates JSDoc. |
| packages/apps/src/app.spec.ts | Updates expectation to always append ;messageid= in 3-arg reply() case. |
| examples/threading/src/index.ts | Removes manual guard, but leaves an outdated “channels only” comment. |
| examples/threading/README.md | Updates command description/notes to reflect service-side behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsThreading()guard fromapp.reply()3-arg form -- always callstoThreadedConversationId()when messageId is providedsupportsThreading()function andTHREADING_SUFFIXESconstant (dead code)supportsThreadingteststest manualexample to remove conversation type guardWhy: Threading support is expanding (channels, 1:1, group chats). Maintaining an allowlist of conversation ID suffixes creates a maintenance burden and can block developers from using newly supported scopes until the SDK is updated.
Test plan
🤖 Generated with Claude Code