Extract threading suffixes to constant#532
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Teams threading utility to centralize the list of conversation ID suffixes that support threading, making the logic easier to maintain and aligning it with the pattern used in the Python SDK.
Changes:
- Extracted thread-capable conversation ID suffixes into a
THREADING_SUFFIXESconstant. - Updated
supportsThreading()to useTHREADING_SUFFIXES.some(...)instead of chainedendsWith()checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
heyitsaamir
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@thread.tacv2,@thread.skype,@unq.gbl.spacessuffixes into aTHREADING_SUFFIXESconstant inthread.tssupportsThreading()now usesTHREADING_SUFFIXES.some()instead of chainedendsWith()callsTest plan
🤖 Generated with Claude Code