feat: add custom feedback loop#522
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support for Teams “feedback loop” configuration, including a new feedbackLoop channelData shape (default vs custom) and the associated message/fetchTask invoke path needed for custom feedback task modules.
Changes:
- Introduces
ChannelData.feedbackLoop(andFeedbackLoopmodel) while keepingfeedbackLoopEnabledas a legacy alias. - Adds normalization logic in
Activity.withChannelData()and extendsActivity.addFeedback()to support'default' | 'custom'modes, with updated tests. - Adds routing/type support for the
message/fetchTaskinvoke (aliases + response typing) and updates devtools’ feedback detection.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devtools/src/stores/ChatStore.ts | Treats channelData.feedbackLoop as enabling feedback in the devtools UI state. |
| packages/apps/src/routes/invoke/index.ts | Adds invoke alias mapping for message/fetchTask → message.fetch-task. |
| packages/apps/src/router/router.spec.ts | Adds coverage ensuring message/fetchTask selects both invoke and message.fetch-task routes. |
| packages/api/src/models/invoke-response.ts | Types message/fetchTask invoke responses as TaskModuleResponse. |
| packages/api/src/models/channel-data/index.ts | Adds feedbackLoop to ChannelData and documents legacy feedbackLoopEnabled. |
| packages/api/src/models/channel-data/feedback-loop.ts | Introduces FeedbackLoop model type (default/custom). |
| packages/api/src/activities/invoke/message/index.ts | Extends message invoke activity union to include fetch-task. |
| packages/api/src/activities/invoke/message/fetch-task.ts | Adds typed representation of the message/fetchTask invoke payload. |
| packages/api/src/activities/activity.ts | Normalizes legacy feedback flag into feedbackLoop; adds addFeedback(mode) support. |
| packages/api/src/activities/activity.spec.ts | Adds test coverage for normalization and custom/default feedback modes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
lilyydu due to an error
April 13, 2026 21:59
heyitsaamir
reviewed
Apr 13, 2026
heyitsaamir
left a comment
heyitsaamir
left a comment
Collaborator
There was a problem hiding this comment.
Any examples you wanna show? The PR description has one
corinagum
reviewed
Apr 14, 2026
corinagum
reviewed
Apr 14, 2026
corinagum
previously approved these changes
Apr 14, 2026
corinagum
left a comment
corinagum
left a comment
Collaborator
There was a problem hiding this comment.
lgtm! just a couple question/nit comments
corinagum
approved these changes
Apr 21, 2026
lilyydu
added a commit
to microsoft/teams.net
that referenced
this pull request
Apr 22, 2026
Custom Feedback Context: [Learn Doc](https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/bot-messages-ai-generated-content?tabs=desktop%2Cjs%2Cbotmessage#feedback-buttons) - previously we had a flag called feedbackLoopEnabled which only enables the default feedback form - now, we have a param called feedbackLoop that can either be default or custom. - updated AI sample to feature the custom feedback loop - also included the normalization to feedbackLoop when using withChannelData.. - py equivalent: microsoft/teams.py#349 - ts equivalent: microsoft/teams.ts#522 --------- Co-authored-by: lilydu <[email protected]> Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Feedback Context:
Learn Doc
feedbackLoopEnabledwhich only enables the default feedback formfeedbackLoopthat can either be default or custom.feedbackLoopwhen usingwithChannelData..