Make messaging endpoint path configurable#483
Merged
heyitsaamir merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
4 tasks
corinagum
reviewed
Mar 24, 2026
corinagum
previously approved these changes
Mar 24, 2026
Collaborator
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
lgtm! one nit on the plugin side
rido-min
reviewed
Mar 24, 2026
Member
rido-min
left a comment
rido-min
left a comment
There was a problem hiding this comment.
can we add an example showing how to configure with a different URL? curious if with this setting we could run to apps with different callback endpoints in the same process
Co-authored-by: Corina <[email protected]>
Collaborator
Author
Hm, I'm not sure if an entire new example is needed to show this option... Maybe just update docs? Ya we could toally have multiple apps with different endpoints: // 1. Create your Express app with your own routes
const expressApp = express();
const httpServer = http.createServer(expressApp);
// 2. Wrap it in the ExpressAdapter
const adapter = new ExpressAdapter(httpServer);
const app1 = new App({ httpServerAdapter: adapter, messagingEndpoint: '/foo' });
await app1.initialize()
const app2 = new App({ httpServerAdapter: adapter, messagingEndpoint: '/bar' });
await app2.initialize()
httpServer.listen(3978, () => console.log('Server ready on http://localhost:3978'));Here both the apps would share the same creds, so we could pass those in manually too if we want them to be serving different bots. This potentially could be a useful example though ^ |
corinagum
approved these changes
Mar 24, 2026
heyitsaamir
added a commit
to microsoft/teams.py
that referenced
this pull request
Mar 24, 2026
## Summary - Currently `/api/messages` is hardcoded as the messaging endpoint path. This might not be always what a developer wants. - Adds `messaging_endpoint` option to `AppOptions` (defaults to `/api/messages`) - `App` is the source of truth for the default; `HttpServer` requires it explicitly - `BotBuilderPlugin` reads the path from `http_server.messaging_endpoint` instead of hardcoding Port of microsoft/teams.ts#483 ## Test plan - [x] Existing `test_http_server.py` tests pass - [x] New test for default messaging endpoint value - [x] New test for custom messaging endpoint registration - [x] Manual test with a custom endpoint path 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: Copilot <[email protected]>
HDYA
pushed a commit
to HDYA/openclaw
that referenced
this pull request
Mar 25, 2026
v2.0.6 replaces the '/api*' wildcard Express route (incompatible with
Express 5 / path-to-regexp v8) with explicit route registration via
registerRoute('POST', messagingEndpoint). The messaging endpoint path
is now configurable (defaults to '/api/messages').
Release notes: https://github.com/microsoft/teams.ts/releases/tag/v2.0.6
Relevant PR: microsoft/teams.ts#483
All 338 msteams tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/api/messagesis hardcoded as the messaging endpoint path. This might not be always what a developer wants.messagingEndpointoption toAppOptions(defaults to/api/messages)Appis the source of truth for the default;HttpServerrequires it explicitlyBotBuilderPluginreads the path fromhttpServer.messagingEndpointinstead of hardcodingTested with
/my-endpointand it worked.