Update quoted replies & new quotes features by corinagum · Pull Request #482 · microsoft/teams.ts

corinagum · 2026-03-23T23:18:54Z

Remove withReplyToId(): replyToId body property has no effect on threading (APX only uses it for encryption)
Add QuotedReplyEntity type with nested quotedReply data object (messageId required, senderId/senderName/preview/time/isReplyDeleted/validatedMessageReference optional)
Add getQuotedMessages() on MessageActivity to read inbound quoted reply entities
Add addQuotedReply(messageId, response?) builder on MessageActivity for constructing outbound quotes (build order = reading order)
Update reply() to stamp quotedReply entity + <quoted messageId="..."/> placeholder instead of blockquote HTML; remove replyToId assignment
Add quoteReply(messageId, activity) on ActivityContext for quoting arbitrary messages
Mark all quoted reply types and methods as @experimental
Fix bug in ActivityContext constructor where Object.assign(this, rest) ran before MessageActivity.from().toInterface(), causing interface methods (getQuotedMessages, stripMentionsText, isRecipientMentioned, getAccountMention) to be missing on context.activity. Added regression test.
Add quoted-replies example exercising all APIs

Copilot

Pull request overview

This PR updates the SDK’s reply/quote behavior to use Teams “quoted replies” (entity + <quoted .../> placeholder) instead of replyToId/blockquote HTML, adds first-class quoted-reply types/APIs, fixes an ActivityContext constructor enrichment bug, and introduces an example app to exercise the new functionality.

Changes:

Add QuotedReplyEntity/QuotedReplyData, plumb into Entity union, and add MessageActivity.getQuotedMessages() + addQuotedReply().
Update ActivityContext.reply() to stamp quoted-reply metadata + placeholder, and add ActivityContext.quoteReply(messageId, ...).
Fix ActivityContext constructor ordering bug (enrichment before Object.assign) and add regression tests + a new quoted-replies example.

Reviewed changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/apps/src/contexts/activity.ts	Adds `quoteReply()` API, changes `reply()` quoting behavior, and fixes constructor activity enrichment ordering.
packages/apps/src/contexts/activity.test.ts	Updates tests to assert quoted-reply entity + placeholder behavior for `reply()` and `quoteReply()`.
packages/apps/src/app.process.spec.ts	Regression test ensuring message activities are enriched with interface methods (e.g., `getQuotedMessages`).
packages/api/src/models/entity/quoted-reply-entity.ts	Introduces `QuotedReplyEntity` and nested quoted reply data model.
packages/api/src/models/entity/index.ts	Exposes `QuotedReplyEntity` via the `Entity` union and exports.
packages/api/src/activities/message/message.ts	Adds `getQuotedMessages()` and `addQuotedReply()` builder API.
packages/api/src/activities/message/message.spec.ts	Adds unit tests for quoted-reply parsing and builder behavior.
packages/api/src/activities/activity.ts	Removes `withReplyToId()` builder method.
packages/api/src/activities/activity.spec.ts	Updates tests to reflect removal of `withReplyToId()`.
package-lock.json	Adds the new `@examples/quoted-replies` workspace entry.
examples/quoted-replies/**	New runnable example demonstrating reading/sending quoted replies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

heyitsaamir

lg2m. Lmk if we change between quoteReply and quote. Both sound ok to me!

corinagum · 2026-04-02T18:09:03Z

Re: Copilot review comments

messageId escaping: messageId is an APX-controlled IC3 ID, not user input. No escaping needed.
Non-message activity guard on reply(): Handled in quote() — non-message activities bypass entity stamping.
withReplyToId() removal: Intentional.
Entity order in prependQuote: Entity position in the list doesn't affect rendering; APX matches by type.
"preview" wording: Updated to "coming soon."

PR #482 left a stale examples/quoted-replies entry (directory was renamed to examples/quoting), and the lockfile predated PR #536's examples/targeted-messages workspace. npm ci enforces lockfile against workspace globs and was failing in CI; npm install tolerated the drift. Regenerated from scratch so both new example workspaces are present and the stale one is gone.

heyitsaamir

Looks good. Minor NIT.

Also, does package-lock need changing?

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

The lockfile had a stale examples/quoted-replies entry left over from the directory rename to examples/quoting, which caused 'npm ci' to fail in CI (npm install tolerated the drift). Regenerated from scratch so the lockfile matches the actual workspace layout.

## Summary Brings `main` into `release` for the 2.0.11 release, with quoted-replies (PR #482) excluded. Single squashed commit containing the diff between `release` (2.0.10) and `main`, minus the quoted-replies feature. ## What's in this release - All commits merged to main since 2.0.10 (the previous release), notably: - **Reactions GA** (PR #575) — `[Experimental]` removed; `ReactionClient.remove()` → `delete()` - User-agent fix (PR #573) - Prompt Preview Support (PR #536) - Various dependency bumps and bug fixes ## What's NOT in this release **Quoted-replies feature (PR #482) is excluded:** - `prependQuote()`, `addQuote()` builder methods — absent - `context.quote()` and quote-aware `reply()` behavior — reverted to legacy `replyToId` + blockquote - `examples/quoting` — removed - QR-related tests — removed **Kept intentionally:** - `QuotedReplyEntity` type stays in the `Entity` union so inbound activities carrying `quotedReply` entities still parse - `addTargetedMessageInfo` runtime strip-QR logic (filters `e.type === 'quotedReply'`) — preserves prompt-preview cleanup ## Version `version.json`: `2.0.10` → `2.0.11` ## Test plan - [x] `npm run lint` — 33/33 packages - [x] `npm run build` — 35/35 packages - [x] `npm run test` — 730/730 tests across 61 suites - [x] `npm pack --workspaces` — all tarballs produced; verified `quoted-reply-entity.d.ts` ships in `@microsoft/teams.api`; no `prependQuote`/`addQuote` symbols in bundled `dist/` - [ ] ADO Public publish pipeline (post-merge) 🤖 Generated with [Claude Code](https://claude.com/claude-code) ## CI note skip-test-verification — the `release` branch is out of sync with `main` for three template/example pairs (templates: `ai`; examples: `echo`, `graph`). This PR brings them along as part of the bulk main→release merge but doesn't try to re-pair them, since that's an orthogonal fix and would muddy this PR's "single squashed release diff" intent.

corinagum force-pushed the cg/quoted-replies branch from 4e0db45 to 70b2cb5 Compare March 23, 2026 23:28

corinagum marked this pull request as ready for review March 24, 2026 18:19

corinagum requested a review from Copilot March 24, 2026 21:43

Copilot started reviewing on behalf of corinagum March 24, 2026 21:44 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

corinagum force-pushed the cg/quoted-replies branch from a85cefa to 1036764 Compare March 24, 2026 23:09

corinagum changed the title ~~Update quoted replies~~ Update quoted replies & new quotes features Mar 25, 2026

heyitsaamir reviewed Mar 25, 2026

View reviewed changes

Comment thread packages/apps/src/contexts/activity.ts

Comment thread packages/apps/src/contexts/activity.ts Outdated

heyitsaamir previously approved these changes Mar 26, 2026

View reviewed changes

corinagum dismissed heyitsaamir’s stale review via 62a7a48 March 26, 2026 23:09

heyitsaamir previously approved these changes Mar 26, 2026

View reviewed changes

corinagum dismissed heyitsaamir’s stale review via 79c74ac April 2, 2026 01:33

corinagum force-pushed the cg/quoted-replies branch from 0596f05 to d7ffcb2 Compare April 7, 2026 19:16

corinagum force-pushed the cg/quoted-replies branch 2 times, most recently from d36b8ac to 2734f5b Compare April 27, 2026 21:53

corinagum force-pushed the cg/quoted-replies branch from 292f241 to b8d2c39 Compare May 6, 2026 23:10

heyitsaamir approved these changes May 7, 2026

View reviewed changes

corinagum force-pushed the cg/quoted-replies branch from b8d2c39 to 8ce52b6 Compare May 7, 2026 17:47

Corina Gum and others added 9 commits May 7, 2026 10:48

Remove withReplyToId

1f16703

Quotes replies feature

40148e6

Quoted replies sample

8ff5948

Mark as experimental in docs and remove replyToId changes in reply

ff6bfa4

Fix binding to rest.activity

a89f452

Update examples

9120625

Update package-lock

c5a40f3

Apply Copilot feedback?

b20f2ca

Add JSDoc for time field format (IC3 epoch)

98ee009

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Corina Gum and others added 6 commits May 7, 2026 10:48

reply defer to quoteReply

0464fa2

Move stamping to model layer

a036d0f

update to quote and verbiage improvements

3b866aa

Rename example

7aac901

Change preview wording to coming soon

cde71ac

corinagum force-pushed the cg/quoted-replies branch from 8ce52b6 to 67aaffd Compare May 7, 2026 17:48

heyitsaamir approved these changes May 7, 2026

View reviewed changes

corinagum merged commit bc4498d into main May 7, 2026
8 checks passed

corinagum deleted the cg/quoted-replies branch May 7, 2026 17:59

corinagum mentioned this pull request May 14, 2026

Release 2.0.11: include main, exclude quoted replies #576

Merged

5 tasks

rajan-chari mentioned this pull request Jun 24, 2026

message handler activity is typed with isRecipientMentioned(), but method is missing at runtime #585

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update quoted replies & new quotes features#482

Update quoted replies & new quotes features#482
corinagum merged 15 commits into
mainfrom
cg/quoted-replies

corinagum commented Mar 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heyitsaamir left a comment •

edited

Loading

Uh oh!

corinagum commented Apr 2, 2026

Uh oh!

heyitsaamir left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

corinagum commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

heyitsaamir left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corinagum commented Apr 2, 2026

Uh oh!

heyitsaamir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

corinagum commented Mar 23, 2026 •

edited

Loading

heyitsaamir left a comment •

edited

Loading