Refactor targeted messaging API to consolidate recipient and targeting flags#449
Merged
Conversation
- Move isTargeted from MessageActivity to base Activity class as non-nullable boolean - Update withRecipient in Activity to accept optional isTargeted parameter - Override withRecipient in MessageActivity to maintain return type - Remove withTargetedRecipient method from MessageActivity - Update all examples and tests to use new API pattern - Update validation error messages - Add isTargeted property to devtools feedback activity Co-authored-by: rido-min <[email protected]>
- Remove unnecessary undefined check in withRecipient - Keep test pattern for update scenario consistent with original implementation Co-authored-by: rido-min <[email protected]>
- Add JSDoc documentation for isTargeted parameter in Activity.withRecipient - Improve comment explaining why isTargeted is set directly in update test Co-authored-by: rido-min <[email protected]>
Copilot
AI
changed the title
[WIP] Apply changes from PR #318 of teams.net
Refactor targeted messaging API to consolidate recipient and targeting flags
Feb 11, 2026
rido-min
marked this pull request as ready for review
February 11, 2026 21:26
rido-min
approved these changes
Feb 12, 2026
corinagum
reviewed
Feb 12, 2026
corinagum
reviewed
Feb 12, 2026
corinagum
reviewed
Feb 12, 2026
corinagum
reviewed
Feb 12, 2026
corinagum
requested changes
Feb 12, 2026
corinagum
left a comment
corinagum
left a comment
Collaborator
There was a problem hiding this comment.
Not sure about the override, nor the package-lock.json touch.
rido-min
requested review from
Jesperholmbergmsft,
dclaux and
ydogandjiev
as code owners
February 18, 2026 00:17
corinagum
reviewed
Feb 18, 2026
corinagum
approved these changes
Feb 18, 2026
Jesperholmbergmsft
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use skip-test-verification
Applies the targeted messaging API refactor from microsoft/teams.net#318. The change consolidates
withTargetedRecipient()into an enhancedwithRecipient()method, making targeted message creation more explicit and reducing API surface area.API Changes
Before:
After:
Implementation
isTargetedfromMessageActivityto baseActivityclass as non-nullable boolean (defaultfalse)Activity.withRecipient(account, isTargeted?)to accept optional targeting flagMessageActivity.withTargetedRecipient()methodBreaking Changes
The
withTargetedRecipient()method is removed. Callers must migrate towithRecipient(account, true).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.