Remove manifest.name check from send() method#416
Merged
Conversation
…igured Remove the unnecessary check for `!this.name` in the `send()` method since the name is already deprecated and not required for sending messages. The app ID is sufficient to ensure the app is properly initialized. When manifest.name is not provided, fallback to using the app ID as the bot name in the ConversationReference. Added tests to verify: - send() works without manifest.name (uses app ID as fallback) - send() works with manifest.name configured - send() throws proper error when app ID is missing Co-authored-by: heyitsaamir <[email protected]>
Copilot
AI
changed the title
[WIP] Fix misleading 'app not started' error in v2.0.4
Remove manifest.name check from send() method
Dec 4, 2025
heyitsaamir
marked this pull request as ready for review
December 5, 2025 02:44
Collaborator
|
Confirmed that this works as expected - tested with no manifest name set, and proactive message was still successfully sent. |
heyitsaamir
approved these changes
Dec 6, 2025
lilyydu
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v2.0.3,
app.namewas changed from readingtokens.bot?.appDisplayNametomanifest.name?.full. Thesend()method's validation checkif (!this.id || !this.name)now throws "app not started" whenmanifest.nameis not provided, even when the app has started successfully.Changes
!this.namevalidation insend()method - only!this.idis requiredmanifest.nameis undefined (name: this.name || this.id)Example
The
app.namegetter is already marked@deprecatedand should not be used for validation.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.