Add signin/failure invoke activity support#404
Merged
Conversation
Co-authored-by: heyitsaamir <[email protected]>
Co-authored-by: heyitsaamir <[email protected]>
Copilot
AI
changed the title
[WIP] Apply similar change from referenced Python PR
Add signin/failure invoke activity support
Nov 18, 2025
Collaborator
|
@copilot looks like it's failing lint. Make sure you lint and test before committing. |
Co-authored-by: heyitsaamir <[email protected]>
Contributor
Author
Collaborator
|
@copilot don't forget to build. The build is failing. |
Co-authored-by: heyitsaamir <[email protected]>
Contributor
Author
heyitsaamir
marked this pull request as ready for review
November 18, 2025 18:50
Jesperholmbergmsft
approved these changes
Nov 19, 2025
corinagum
added a commit
that referenced
this pull request
Apr 27, 2026
Follow-up to the allowlist feature (shipped via #515). No runtime behavior change for correct callers. Adds hardening informed by review feedback on the sibling Python PR (microsoft/teams.py#404): 1. **Docstring clarity.** `App.additionalAllowedDomains`, `HttpServerOptions`, and `ServiceTokenValidator` constructor all document that entries must be bare hostnames matched exactly (case-insensitive); wildcard patterns like `*.example.com`, URL suffixes, and full URLs are NOT supported. `['*']` is the sole wildcard, used as a disable-validation sentinel. 2. **Defensive copy.** `HttpServer` and `ServiceTokenValidator` no longer store the caller's array by reference. A post-construction mutation of the caller's array would previously have changed validator behavior at runtime; now it is isolated. 3. **Tests** covering the class of bug Python shipped in #404: plumbing from `HttpServerOptions` through `HttpServer.initialize()` into the `ServiceTokenValidator` constructor. --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add signin/failure invoke activity support to teams.ts
This PR applies the same changes from the Python PR microsoft/teams.py#206 to add support for signin/failure invoke activities.
Changes Made:
Summary:
Successfully resolved the issue where
signin/failureinvoke activities would cause validation errors. The implementation follows the exact same pattern as the Python PR microsoft/teams.py#206, adapting it to TypeScript conventions.Problem
When sign-in failures occurred, the system would throw validation errors because the
signin/failureinvoke activity type was not supported.Solution
Added complete support for the
signin/failureinvoke activity type:codeandmessagefields to capture failure detailssignin/failureeventsImpact
Before: Sign-in failures would cause validation errors and prevent proper error handling.
After: Sign-in failures are gracefully handled:
Breaking Changes
None - fully backward compatible. Only adds new functionality.
Security Summary
No security vulnerabilities were introduced by these changes. CodeQL analysis found no alerts.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.