Add support for federated identity credentials#389
Merged
Conversation
This was referenced Nov 7, 2025
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
November 8, 2025 00:40
aac8819 to
62ae20b
Compare
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 8, 2025 00:40
85ed85e to
a75d09c
Compare
heyitsaamir
marked this pull request as ready for review
November 8, 2025 00:42
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 8, 2025 00:55
94da2d6 to
b6f81e7
Compare
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
November 11, 2025 01:11
5af5715 to
407c560
Compare
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 11, 2025 01:11
b6f81e7 to
10057f5
Compare
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
November 11, 2025 01:18
407c560 to
d067c7e
Compare
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 11, 2025 01:18
10057f5 to
df2078a
Compare
rido-min
approved these changes
Nov 11, 2025
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
November 11, 2025 17:51
d067c7e to
9ec2157
Compare
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 11, 2025 17:51
df2078a to
892a823
Compare
lilyydu
approved these changes
Nov 11, 2025
| /** | ||
| * client id - Your application's client identifier | ||
| * Uses environment variable CLIENT_ID if not explicitly provided | ||
| * If not available, uses |
Contributor
There was a problem hiding this comment.
missing MI part in latter statement
heyitsaamir
force-pushed
the
aamirj/UMI
branch
from
November 11, 2025 20:07
9ec2157 to
8a6aab3
Compare
heyitsaamir
force-pushed
the
aamirj/FIC
branch
from
November 11, 2025 20:07
1389155 to
db8807e
Compare
heyitsaamir
added a commit
that referenced
this pull request
Nov 12, 2025
This PR introduces MSAL as a dependency and switches our supported bot authentication to use it. It also includes support for User Managed Identity support and FIC such that we don't need to provide custom code to do that anymore as we had previously suggested. Instead, we can do that simply by the environment variables. | CLIENT_ID | CLIENT_SECRET | MANAGED_IDENTITY_CLIENT_ID | Output | |-|-|-|-| | not_set | | | No-Auth | | set | set | | SecretsAuth | | set | not_set | | User Managed Identity Auth | | set | not_set | set (same as CLIENT_ID) | User Managed Identity Auth | | set | not_set | set (diff from CLIENT_ID) | FIC (user managed identity) | | set | not_set | "system" | FIC (system identity) | Changes to note: 1. We are now no longer _proactively_ refreshing tokens. Instead, we put the token fetcher inside the token resolver logic for the client. This ends up being a call to `tokenManager.getBotToken`. 2. This fixes a bug where proactive scenarios were going to fail because we weren't refreshing the token for them. For reactive scenarios, we refresh the token when the request comes in, so it was fine. 3. We are deprecating the `id` and `name` fields because those used to depend on the token being present. Now that we are not proactively fetching the token, those are not as useful (or reliable). For now, I have chosen to simply use the value from the manifest to populate them. I don't think these fields were that useful anyway, so opting to deprecate. 4. Removes graphToken from being injected into plugins. Plugins weren't using it, and we want to remove tight dependency on graph package. #### PR Dependency Tree * **PR #387** 👈 * Merged #388, #389, #392 This tree was auto-generated by [Charcoal](https://github.com/danerwilliams/charcoal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds native support for Federated Identity Credentials (User and System) via MSAL.
PR Dependency Tree
This tree was auto-generated by Charcoal