Skip to content

Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout)#382

Merged
heyitsaamir merged 4 commits into
mainfrom
revert-381-patch-1
Oct 29, 2025
Merged

Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout)#382
heyitsaamir merged 4 commits into
mainfrom
revert-381-patch-1

Conversation

@heyitsaamir

@heyitsaamir heyitsaamir commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

Reverts #381

This is a bit of mess -

  • There is an AttachmentLayout that exists on Activity which should be list | carousel.
  • There is an AttachmentLayout that exists on MessageExtension which should be list | grid.

@heyitsaamir
heyitsaamir marked this pull request as draft October 27, 2025 19:25
@heyitsaamir
heyitsaamir marked this pull request as ready for review October 27, 2025 19:41
@heyitsaamir heyitsaamir changed the title Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessageExtensionAttachmentLayout) Oct 27, 2025
corinagum
corinagum previously approved these changes Oct 27, 2025
Comment thread packages/api/src/models/messaging-extension/messaging-extension-result.ts Outdated
aacebo
aacebo previously approved these changes Oct 27, 2025
@heyitsaamir
heyitsaamir dismissed stale reviews from aacebo and corinagum via 9ce6c02 October 28, 2025 21:56
@heyitsaamir heyitsaamir changed the title Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessageExtensionAttachmentLayout) Revert "[🐞fix] Change AttachmentLayout type to replace 'carousel' with correct value: 'grid'" (And add MessagingExtensionAttachmentLayout) Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants