fix: update invalid inbound/outbound activities by rajan-chari · Pull Request #340 · microsoft/teams.py

rajan-chari · 2026-03-31T22:21:19Z

Summary

Fixes #338.

removed:

ConversationUpdateActivityInput
- invalid outbound activity that fails service validation
inbound and outbound HandoffActivity
- not recognized by backend
- BF has a similar event but it uses type: "event" + name: "handoff.initiate"
- similiarly exists for copilot but it is only inbound as HandoffActionInvokeActivity which we have
inbound and outbound TraceActivity
- not recognized by backend
- is only for the BF Emulator which is now deprecated. doc ref
MessageDeleteActivityInput
- invalid outbound activity that fails service validation
- will be provided in a new API endpoint instead
MessageUpdateActivityInput
- invalid outbound activity that fails service validation
CommandSendActivityInput
- invalid outbound activity that fails service validation
- not a Teams concept. it's a BF activity type used in the skills protocol — where one bot sends a command to a skill bot and gets a commandResult back.
CommandResultActivityInput
- not recognized by backend
- not a Teams concept, it's a BF skill that sends back to the parent bot after completing a command.

Copilot

Pull request overview

This PR updates the outbound “sendable activity” typing surface in the Teams API package to better reflect what the Bot Framework /v3/conversations/{id}/activities endpoints accept, aligning the SDK’s type promises with runtime behavior (Fixes #338).

Changes:

Narrow ActivityParams to only include MessageActivityInput, TypingActivityInput, and (temporarily) MessageReactionActivityInput.
Remove several inbound-only *ActivityInput types from the outbound ActivityParams union to prevent users from attempting unsupported sends.

The ActivityParams union included 10 *ActivityInput types, but the Teams service (APX) only accepts `message` and `typing` on outbound POST/PUT. The other types (messageDelete, messageUpdate, conversationUpdate, handoff, trace, commandSend, commandResult) are inbound-only event notifications — sending them produces gateway errors. Narrowing the union to MessageActivityInput, TypingActivityInput, and MessageReactionActivityInput (kept temporarily — needs its own send path via the reactions API) so the type system matches what actually works at runtime. The *ActivityInput classes themselves are preserved for model symmetry; only the union membership changes. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Rewrite header comment to explain the union's purpose without internal terminology. Explicitly call out MessageReactionActivityInput as a temporary inclusion pending its own send path. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

rajan-chari · 2026-04-01T00:06:09Z

Manual Test Results — Echo Bot (Python)

Tested on branch fix/338-rename-activity-params (PR #342, which stacks on this PR), commit bf62a5c. Python echo bot deployed to BAMI1 tenant via DevTunnel.

#	Test	Result	Details
1	Send a message → bot replies	PASS	Sent "Hello from bolt test" → bot replied "You said 'Hello from bolt test'" (`MessageActivityInput` via `ctx.send(str)`)
2	Bot shows typing indicator before reply	PASS	`TypingActivityInput` sent in handler before reply
3	Edit a sent message → `@app.on_message_update` fires	PASS	Edited message → bot replied "Message updated: 'Hello from bolt test EDITED'"
4	Delete a message → `@app.on_message_delete` fires	PASS	Deleted message → bot replied "A message was deleted."
5	No regression in send/typing	PASS	Both `MessageActivityInput` and `TypingActivityInput` work after narrowing the union

All 5 test steps from the test plan passed. The narrowed sendable union (message + typing only) works correctly; incoming event handlers are unaffected.

lilyydu · 2026-04-01T18:30:09Z

I did another pass with Claude and based on scanning APX repo - it accepts message, command, and typing:

MessageUpdateActivityInput and MessageDeleteActivityInput can use PUT and DELETE respectively on
/v3/conversations/{id}/activities/{activityId}
CommandSendActivityInput is handled by POST

thus, MessageUpdateActivityInput, MessageDeleteActivityInput, and CommandSendActivityInput should remain in ActivityParams

Can you re-test different requests with these activities to verify acurracy?

heyitsaamir

Makes sense to me. @lilyydu based on your models work, I think you're better suited to approve.

Edit: saw your message above.

jerbob92 · 2026-04-02T15:41:58Z

Why keep messageReaction? There is no currently no option to set a reaction from a bot right?

I did another pass with Claude and based on scanning APX repo - it accepts message, command, and typing:

MessageUpdateActivityInput and MessageDeleteActivityInput can use PUT and DELETE respectively on
/v3/conversations/{id}/activities/{activityId}

CommandSendActivityInput is handled by POST

thus, MessageUpdateActivityInput, MessageDeleteActivityInput, and CommandSendActivityInput should remain in ActivityParams

Can you re-test different requests with these activities to verify acurracy?

When I tried it out, at least MessageDeleteActivityInput did not work because it's not routed to the correct operation (only update and create are handled in send).

equivalent to these 2 python PRs: microsoft/teams.py#340 (not all applicable bc TS doesnt have defined inbound/outbound interfaces) microsoft/teams.py#336 This pull request adds deprecation warnings to several activity-related interfaces and types to clarify that certain properties and activities are no longer recognized or returned by the service backend. This improves the clarity of the API and helps developers avoid using obsolete features. Verified with APX repo and manual testing. **Deprecation of properties and activities:** * Marked the `relatesTo` property as deprecated in the base `IActivity` interface, the `Activity` class, and in all derived activity interfaces where it appears, indicating it is no longer returned by the backend. * Added `@deprecated` annotations to the `withRelatesTo` method in the `Activity` class for consistency. **Deprecation of activity types not recognized by the backend:** * Marked the `IHandoffActivity` and `ITraceActivity` interfaces as deprecated * Marked the `IEndOfConversationActivity` interface and `EndOfConversationCode` type as deprecated --------- Co-authored-by: lilydu <[email protected]> Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings March 31, 2026 22:21

Copilot started reviewing on behalf of rajan-chari March 31, 2026 22:25 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Comment thread packages/api/src/microsoft_teams/api/activities/activity_params.py Outdated

rajan-chari force-pushed the fix/338-remove-unsendable-input-types branch from f150bd0 to 2b7b7f8 Compare March 31, 2026 22:35

This was referenced Mar 31, 2026

chore: remove dead *ActivityInput classes for inbound-only types #341

Closed

refactor: rename ActivityParams → SendableActivity #342

Closed

feat: add ctx.delete(activity_id) convenience method #343

Closed

rajan-chari requested review from heyitsaamir and lilyydu April 1, 2026 00:20

heyitsaamir reviewed Apr 1, 2026

View reviewed changes

lilyydu changed the title ~~fix: remove unsendable activity types from ActivityParams union~~ fix: update invalid inbound/outbound activities Apr 3, 2026

lilydu added 3 commits April 3, 2026 11:04

updated

c4f4b4b

merge w main

7029bde

merge w main

8156fef

heyitsaamir approved these changes Apr 6, 2026

View reviewed changes

lilyydu mentioned this pull request Apr 6, 2026

[Bug]: Updating/deleting messages is not clear #338

Closed

lilyydu merged commit 493ce1f into main Apr 6, 2026
7 checks passed

lilyydu deleted the fix/338-remove-unsendable-input-types branch April 6, 2026 20:54

lilyydu mentioned this pull request Apr 9, 2026

Release: merge main into alpha/v2.0.0 #377

Merged

heyitsaamir mentioned this pull request Apr 10, 2026

Release: merge main into alpha/v2.0.0 #379

Closed

4 tasks

lilyydu mentioned this pull request Apr 14, 2026

address model gaps microsoft/teams.ts#525

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: update invalid inbound/outbound activities#340

fix: update invalid inbound/outbound activities#340
lilyydu merged 5 commits into
mainfrom
fix/338-remove-unsendable-input-types

rajan-chari commented Mar 31, 2026 •

edited by lilyydu

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

rajan-chari commented Apr 1, 2026

Uh oh!

lilyydu commented Apr 1, 2026 •

edited

Loading

Uh oh!

heyitsaamir left a comment •

edited

Loading

Uh oh!

jerbob92 commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

rajan-chari commented Mar 31, 2026 • edited by lilyydu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rajan-chari commented Apr 1, 2026

Manual Test Results — Echo Bot (Python)

Uh oh!

lilyydu commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heyitsaamir left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerbob92 commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rajan-chari commented Mar 31, 2026 •

edited by lilyydu

Loading

lilyydu commented Apr 1, 2026 •

edited

Loading

heyitsaamir left a comment •

edited

Loading