Replace HttpPlugin with HttpServer + HttpServerAdapter#310
Merged
Conversation
heyitsaamir
force-pushed
the
aamirj/http-server-adapter
branch
from
March 11, 2026 06:31
89da9ae to
99286e3
Compare
heyitsaamir
force-pushed
the
aamirj/http-server-adapter
branch
from
March 11, 2026 22:43
99286e3 to
a0852a3
Compare
lilyydu
reviewed
Mar 11, 2026
heyitsaamir
commented
Mar 12, 2026
heyitsaamir
added a commit
that referenced
this pull request
Mar 12, 2026
- Remove duplicate DI registration ("server" key)
- Add docstring to HttpServerAdapter protocol
- Replace assert with ValueError in FastAPIAdapter
- Let _process_activity errors propagate to _handle_activity
- Upgrade Teams JS SDK from v1.11.0 to v2.31.1 in dialog example
- Add streaming examples to http-adapter examples
Co-Authored-By: Claude Opus 4.6 <[email protected]>
lilyydu
approved these changes
Mar 12, 2026
heyitsaamir
added a commit
that referenced
this pull request
Mar 12, 2026
- Remove duplicate DI registration ("server" key)
- Add docstring to HttpServerAdapter protocol
- Replace assert with ValueError in FastAPIAdapter
- Let _process_activity errors propagate to _handle_activity
- Upgrade Teams JS SDK from v1.11.0 to v2.31.1 in dialog example
- Add streaming examples to http-adapter examples
Co-Authored-By: Claude Opus 4.6 <[email protected]>
heyitsaamir
force-pushed
the
aamirj/http-server-adapter
branch
from
March 12, 2026 19:40
697c7e2 to
21d0bf6
Compare
heyitsaamir
force-pushed
the
aamirj/simplifyHttp
branch
from
March 12, 2026 19:45
8dc943a to
2c91aa4
Compare
heyitsaamir
added a commit
that referenced
this pull request
Mar 12, 2026
- Remove duplicate DI registration ("server" key)
- Add docstring to HttpServerAdapter protocol
- Replace assert with ValueError in FastAPIAdapter
- Let _process_activity errors propagate to _handle_activity
- Upgrade Teams JS SDK from v1.11.0 to v2.31.1 in dialog example
- Add streaming examples to http-adapter examples
Co-Authored-By: Claude Opus 4.6 <[email protected]>
heyitsaamir
force-pushed
the
aamirj/http-server-adapter
branch
from
March 12, 2026 19:45
6e331d7 to
a5de748
Compare
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
Move to HttpServer instead of HttPlugin following the TS PR.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Remove duplicate DI registration ("server" key)
- Add docstring to HttpServerAdapter protocol
- Replace assert with ValueError in FastAPIAdapter
- Let _process_activity errors propagate to _handle_activity
- Upgrade Teams JS SDK from v1.11.0 to v2.31.1 in dialog example
- Add streaming examples to http-adapter examples
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add lifespans list to FastAPIAdapter so plugins can chain their lifespans into the FastAPI app. The MCP server plugin uses this to ensure FastMCP's session manager task group is initialized. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Removes unnecessary indirection — every plugin only used server.adapter. Now plugins inject the adapter directly via Annotated[HttpServerAdapter, DependencyMetadata()]. Also adds proper ASGIApp typing for lifespans and port mismatch warning. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
heyitsaamir
force-pushed
the
aamirj/http-server-adapter
branch
from
March 13, 2026 06:02
86038d4 to
daec143
Compare
heyitsaamir
added a commit
that referenced
this pull request
Apr 7, 2026
HttpPlugin was replaced by HttpServer + HttpServerAdapter in PR #310 but the file was accidentally left behind. Remove it along with its sole dependency (create_jwt_validation_middleware) and associated tests. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpPluginwithHttpServer+HttpServerAdapterpattern — follows the TS PR #433 approachHttpServeris no longer a plugin — it's owned directly byAppHttpServerAdapterprotocol withFastAPIAdapteras the default implementationHttpServervia DI and access the framework viaserver.adapterasync (HttpRequest) -> HttpResponseremote_function_jwt_middlewareto be framework-agnosticexamples/http-adapters/with Starlette adapter and non-managed FastAPI examplesStacked on #249
Test plan
poe test— all tests pass🤖 Generated with Claude Code