fix: naming error on aad_object_id for TeamsChannelAccount#300
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a field naming error in TeamsChannelAccount, renaming object_id to aad_object_id to correctly match the Microsoft Teams Bot Framework API's aadObjectId JSON field. The CustomBaseModel alias generator converts aad_object_id (snake_case) to aadObjectId (camelCase) for JSON deserialization/serialization, which aligns with the official .NET SDK documentation.
Changes:
TeamsChannelAccount.object_idrenamed toaad_object_id, aligning it with theaadObjectIdTeams API field and matching the existingAccount.aad_object_idfield naming convention.
corinagum
approved these changes
Mar 3, 2026
lilyydu
added a commit
to microsoft/teams.ts
that referenced
this pull request
Mar 17, 2026
- property was incorrectly named `objectId` instead of `aadObjectId`, field was being dropped during serialization when the `meetingEnd` event was triggered - schema that we are using: https://learn.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.teams.teamschannelaccount?view=botbuilder-dotnet-stable - equivalent python fix: microsoft/teams.py#300 - dotnet has it correctly set Co-authored-by: lilydu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously named
object_id- should beaad_object_idhttps://learn.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.teams.teamschannelaccount?view=botbuilder-dotnet-stable