Simplify targeted messages with with_recipient() overload by Copilot · Pull Request #275 · microsoft/teams.py

Copilot · 2026-02-11T21:06:35Z

Summary

Applied changes from microsoft/teams.net#318 to simplify targeted messages API.

Changes Completed

API Migration

Before: message.with_targeted_recipient(True) or message.with_targeted_recipient("user-id")
After: message.with_recipient(account, is_targeted=True)

Key Design Decisions

is_targeted is Optional[bool] = None: Avoids serializing isTargeted: false for all activities, preventing potential wire-format compatibility issues with Bot Framework/Teams endpoints
with_recipient() only sets is_targeted when explicitly specified: Prevents silently clearing the flag when just updating recipient. Pass is_targeted=True to enable targeting, is_targeted=False to explicitly clear it, or omit/pass None to leave unchanged
Validation at send time: Clear error messages when targeted messages lack recipients, preventing 4xx errors from the service

Breaking Change

This is a breaking change requiring updates to all code using targeted messages. Recipients must now be explicitly set using Account objects.

Co-authored-by: rido-min [email protected]

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: rido-min <[email protected]>

rido-min · 2026-02-11T21:29:20Z

@copilot there are some errors, can you fix this

Copilot

Pull request overview

This PR updates the Python Teams SDK’s targeted messaging API by consolidating behavior into a single with_recipient(account, is_targeted=...) method, removing with_targeted_recipient() and eliminating implicit recipient inference during ActivityContext.send().

Changes:

Moves is_targeted onto ActivityInput and adds an is_targeted parameter to with_recipient().
Removes automatic recipient inference in ActivityContext.send() and updates proactive validation messaging.
Migrates tests and the targeted-messages example to the new explicit-recipient pattern.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/apps/tests/test_http_plugin.py	Updates targeted send test to use `with_recipient(..., is_targeted=True)` with an explicit `Account`.
packages/apps/tests/test_app.py	Adjusts proactive targeted-message tests to the new API and manual `is_targeted` flag setting.
packages/apps/tests/test_activity_context.py	Updates targeted-message context-send tests to require explicit recipient instead of inference.
packages/apps/src/microsoft_teams/apps/routing/activity_context.py	Removes targeted recipient auto-inference logic in `send()`.
packages/apps/src/microsoft_teams/apps/app.py	Updates proactive targeted-message validation error text to reference `with_recipient(...)`.
packages/api/tests/unit/test_message_activities.py	Replaces `with_targeted_recipient` tests with `with_recipient(..., is_targeted=...)` coverage.
packages/api/src/microsoft_teams/api/models/activity.py	Adds `is_targeted` to `ActivityInput` and extends `with_recipient()` signature to set targeted behavior.
packages/api/src/microsoft_teams/api/activities/message/message.py	Removes `_MessageBase.is_targeted` and routes message `with_recipient()` to the base implementation.
examples/targeted-messages/src/main.py	Migrates example usage to explicit-recipient targeted sends/replies/updates/deletes.

Co-authored-by: rido-min <[email protected]>

Copilot · 2026-02-11T21:31:26Z

@copilot there are some errors, can you fix this

Fixed in 7bf13a9. The test was asserting is_targeted is None, but since we moved is_targeted to the base ActivityInput class as a non-nullable bool (default False), it now correctly checks for False instead.

rido-min · 2026-02-11T21:58:20Z

@copilot apply changes based on the comments in this thread

…avior - Change is_targeted from bool=False to Optional[bool]=None to avoid serializing false for all activities - Update with_recipient() to only set is_targeted when explicitly specified (prevents silently clearing flag) - Add validation in ActivityContext.send() for targeted messages without recipients - Update error message to refer to "account" instead of "ID" - Remove unused Account import from targeted-messages example - Update test assertions to expect None for unset is_targeted Co-authored-by: rido-min <[email protected]>

Copilot · 2026-02-11T22:00:46Z

@copilot apply changes based on the comments in this thread

Applied all review comments in e193c15:

Removed unused Account import from examples
Changed is_targeted to Optional[bool] = None to avoid serializing false for all activities
Made is_targeted parameter optional in with_recipient() - only sets when explicitly specified
Added validation in ActivityContext.send() for targeted messages without recipients
Updated error messages to reference "account" instead of "ID"

rido-min · 2026-02-11T23:28:51Z

@copilot fix the errors

The test was expecting "explicit recipient ID" but the error message was updated to say "explicit recipient account". Co-authored-by: rido-min <[email protected]>

Copilot · 2026-02-11T23:30:21Z

@copilot fix the errors

Fixed in 2c517fa. Updated test regex to match the new error message "explicit recipient account" instead of "explicit recipient ID".

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot <[email protected]>

…esc sample down

…to set recipient for targeted on first activity, remove value error throw

Initial plan

d8e24fb

Copilot AI assigned Copilot and rido-min Feb 11, 2026

Copilot started work on behalf of rido-min February 11, 2026 21:06 View session

Copilot AI and others added 2 commits February 11, 2026 21:10

Refactor targeted messages API to use with_recipient overload

60f513a

Co-authored-by: rido-min <[email protected]>

Fix whitespace issues in docstrings

01ef7e6

Co-authored-by: rido-min <[email protected]>

Copilot AI changed the title ~~[WIP] Apply changes from PR 318 to current repository~~ Simplify targeted messages with with_recipient() overload Feb 11, 2026

Copilot AI requested a review from rido-min February 11, 2026 21:15

Copilot finished work on behalf of rido-min February 11, 2026 21:15

rido-min marked this pull request as ready for review February 11, 2026 21:25

Copilot AI review requested due to automatic review settings February 11, 2026 21:25

Merge branch 'main' into copilot/apply-changes-from-pr-318

b6358f7

Copilot started reviewing on behalf of rido-min February 11, 2026 21:26 View session

Copilot started work on behalf of rido-min February 11, 2026 21:29 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Fix test: is_targeted is now bool (False) not None

7bf13a9

Co-authored-by: rido-min <[email protected]>

Copilot finished work on behalf of rido-min February 11, 2026 21:32

Copilot started work on behalf of rido-min February 11, 2026 21:58 View session

Copilot finished work on behalf of rido-min February 11, 2026 22:01

rido-min requested a review from Copilot February 11, 2026 23:27

Copilot started reviewing on behalf of rido-min February 11, 2026 23:27 View session

Copilot AI mentioned this pull request Feb 11, 2026

Update targeted messages docs to reflect consolidated API microsoft/teams-sdk#2711

Merged

Copilot started work on behalf of rido-min February 11, 2026 23:29 View session

Fix test error message regex to match updated error text

2c517fa

The test was expecting "explicit recipient ID" but the error message was updated to say "explicit recipient account". Co-authored-by: rido-min <[email protected]>

Copilot finished work on behalf of rido-min February 11, 2026 23:31

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Comment thread packages/apps/tests/test_app.py

Comment thread packages/apps/tests/test_app.py Outdated

Comment thread packages/apps/src/microsoft_teams/apps/routing/activity_context.py Outdated

rido-min approved these changes Feb 12, 2026

View reviewed changes

rido-min requested a review from Copilot February 12, 2026 01:39

Copilot started reviewing on behalf of rido-min February 12, 2026 01:40 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

lilyydu approved these changes Feb 12, 2026

View reviewed changes

Comment thread packages/apps/tests/test_app.py Outdated

Comment thread packages/apps/tests/test_http_plugin.py Outdated

Comment thread packages/apps/tests/test_app.py Outdated

rido-min and others added 2 commits February 17, 2026 16:39

Update packages/apps/tests/test_app.py

63aada9

Co-authored-by: Copilot <[email protected]>

Fix import statement for Account in test_http_plugin.py

a5871e2

lilyydu approved these changes Feb 18, 2026

View reviewed changes

rido-min and others added 5 commits February 18, 2026 09:24

Merge branch 'main' into copilot/apply-changes-from-pr-318

0d3741d

Merge branch 'main' into copilot/apply-changes-from-pr-318

9c776cb

Merge branch 'main' into copilot/apply-changes-from-pr-318

d9651ec

lint fix & add check for MessageActivityInput, flip to True & moved d…

0844428

…esc sample down

remove devtools, update send to all members, update activity context …

8f2bdee

…to set recipient for targeted on first activity, remove value error throw

rido-min approved these changes Feb 19, 2026

View reviewed changes

lilyydu merged commit f392afb into main Feb 19, 2026
7 checks passed

lilyydu deleted the copilot/apply-changes-from-pr-318 branch February 19, 2026 22:58

Uh oh!

Conversation

Copilot AI commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Completed

API Migration

Key Design Decisions

Breaking Change

Uh oh!

rido-min commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

rido-min commented Feb 11, 2026

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

rido-min commented Feb 11, 2026

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Feb 11, 2026 •

edited

Loading