Remove jitter during streaming#248
Merged
Merged
Conversation
heyitsaamir
commented
Jan 25, 2026
Removed unused import of HTTPStatusError from retry.py.
heyitsaamir
commented
Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses retry jitter issues during streaming that were causing rate limit errors (429s). The changes remove jitter from retry logic and adjust retry parameters to prevent exhausting retries too quickly.
Changes:
- Removed retry jitter (jitter_type="none") and adjusted retry parameters (max_attempts=8, max_delay=4.0) for streaming operations to prevent premature retry exhaustion
- Improved notification mechanism by replacing polling with asyncio.Event for more efficient state change detection
- Added special debug-level logging for expected 429 rate limit errors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apps/src/microsoft_teams/apps/http_stream.py | Updated retry options for _send_activity() to use no jitter, 8 attempts, and 4s max delay; replaced polling with Event-based state change notification |
| packages/apps/src/microsoft_teams/apps/utils/retry.py | Added HTTPStatusError import and special handling to log 429 rate limit errors at debug level instead of error level |
| packages/apps/tests/test_http_stream.py | Updated test assertion from 5 to 8 calls to match new max_attempts value |
MehakBindra
approved these changes
Jan 26, 2026
heyitsaamir
added a commit
that referenced
this pull request
Jan 28, 2026
# Release version 2.0.0a9 Commits since v2.0.0a8: - Add support for Python 3.14 (#259) - Bump qs from 6.14.0 to 6.14.1 in /examples/tab/Web (#240) - Bump urllib3 from 2.5.0 to 2.6.3 (#251) - Bump authlib from 1.6.5 to 1.6.6 (#252) - Bump starlette from 0.48.0 to 0.49.1 (#261) - Bump fastmcp from 2.12.4 to 2.14.0 (#260) - Bump python-multipart from 0.0.20 to 0.0.22 (#254) - Bump virtualenv from 20.35.3 to 20.36.1 (#256) - Bump pyasn1 from 0.6.1 to 0.6.2 (#255) - Bump azure-core from 1.36.0 to 1.38.0 (#257) - Bump aiohttp from 3.13.0 to 3.13.3 (#258) - fix meetingStart and meetingEnd casing bug & add meetings sample (#246) - Remove jitter during streaming (#248) - Add SERVICE_URL to override default service_url for Teams (#247) - [Fix] streaming: do not reset timeout for each emit, do not wait forever on close stream (#197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With jitter=full, sometimes we reduce our waits too too short (like if it was going to be 2s, it becomes like 0.5s). This leads to us eating through all our retries and getting a 429. Our service more aggressive than originally thought, so we need to keep jitter to none.